Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic consumer acknowledgements #31

Open
naggingant opened this issue Jun 8, 2020 · 1 comment
Open

Semantic consumer acknowledgements #31

naggingant opened this issue Jun 8, 2020 · 1 comment

Comments

@naggingant
Copy link
Member

No description provided.

@naggingant naggingant mentioned this issue Jun 8, 2020
Merged
@naggingant
Copy link
Member Author

naggingant commented Jul 14, 2020 •
edited
Loading

On RPCs, we should make sure these errors would not trigger retries and the message should be (negatively, when appropriate) acknowledged immediately:

  • TypeError
  • RangeError
  • ReferenceError
  • SyntaxError
  • assert.AssertionError

https://github.com/openrm/hato/blob/aff5a27/plugins/retry/errors.js#L31

See also https://nodejs.org/api/errors.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naggingant