From cdc42044c7be5c727b8eb012ff92e51749e6bd4d Mon Sep 17 00:00:00 2001 From: Sandesh Kumar Date: Mon, 11 Mar 2024 17:08:10 -0700 Subject: [PATCH] Rewording for changelog and minor documentation changes Signed-off-by: Sandesh Kumar --- CHANGELOG.md | 2 +- .../bucket/terms/GlobalOrdinalsStringTermsAggregator.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2be1d8eda34f6..7f0118711126e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -128,7 +128,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ### Changed - Allow composite aggregation to run under a parent filter aggregation ([#11499](https://github.com/opensearch-project/OpenSearch/pull/11499)) -- Improve string terms aggregation performance using Collector#setWeight ([#11643](https://github.com/opensearch-project/OpenSearch/pull/11643)) +- Quickly compute terms aggregations when the top-level query is functionally match-all for a segment ([#11643](https://github.com/opensearch-project/OpenSearch/pull/11643)) ### Deprecated diff --git a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java b/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java index 15e538f01e632..69fda2f3f6133 100644 --- a/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java +++ b/server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java @@ -159,7 +159,7 @@ public void setWeight(Weight weight) { } /** - Collects term frequencies for a given field from a LeafReaderContext directly from stored segment terms + Read doc frequencies directly from indexed terms in the segment to skip iterating through individual documents @param ctx The LeafReaderContext to collect terms from @param globalOrds The SortedSetDocValues for the field's ordinals @param ordCountConsumer A consumer to accept collected term frequencies