Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote cluster state] Few custom metadata not getting persisted on storage which dont support async write. #10697

Closed
dhwanilpatel opened this issue Oct 18, 2023 · 1 comment
Labels
bug Something isn't working Cluster Manager Storage:Remote Storage Issues and PRs relating to data and metadata storage v2.12.0 Issues and PRs related to version 2.12.0

Comments

@dhwanilpatel
Copy link
Contributor

Describe the bug
We rely on writeAsync method of ChecksumBlobStoreFormat to write the global metadata to remote store. writeAsync method internally calls the write method for the cases where async write is not supported. In write method we have hard coded the Snapshot context, so few of the custom metadata will not be persisted in remote store for the store where async write is not supported.

final BytesReference bytes = serialize(obj, blobName, compressor, SNAPSHOT_ONLY_FORMAT_PARAMS);

Fix
We will need to expose XContentContext parms in write method as well and pass the context of remote store from writeAsync method to write method.

Meta issue: #10523

@dhwanilpatel
Copy link
Contributor Author

Duplicate of : #10691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cluster Manager Storage:Remote Storage Issues and PRs relating to data and metadata storage v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

No branches or pull requests

2 participants