Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Error in the 1.3.x Version of the Documentation #4936

Closed
2 of 4 tasks
paulkoehlerdev opened this issue Aug 29, 2023 · 4 comments
Closed
2 of 4 tasks

[DOC] Error in the 1.3.x Version of the Documentation #4936

paulkoehlerdev opened this issue Aug 29, 2023 · 4 comments
Assignees
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. Sev2 High-medium priority. Upcoming release or incorrect information.

Comments

@paulkoehlerdev
Copy link

paulkoehlerdev commented Aug 29, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

The problem seems to be in the configuration reference for Creating a cluster for the Version 1.3.x in the section about the cluster_manager node.

In this version cluster_manager is still master.

That means:

node.roles: [ cluster_manager ]

should be:

node.roles: [ master ]

This issue is probably also reflected in the node types, as the cluster_manager-elegible node type seems to be new in OpenSearch 2.x

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. Sev2 High-medium priority. Upcoming release or incorrect information. and removed untriaged labels Sep 6, 2023
@Dantochi
Copy link

Hi 👋, I'm new to open source contribution and looking forward to dealing my first issue. Please could you tell me how I may go about the number 2 task "Adding new documentation". I'd like to help...🙏

@BigSamu
Copy link
Contributor

BigSamu commented Oct 16, 2023

@Naarcha-AWS I would like to take this issue if @Dantochi don't want to take it anymore

BigSamu added a commit to BigSamu/documentation-website that referenced this issue Oct 17, 2023
Changing configuration reference line 84 from 'cluster_manager' to 'master' (Issue opensearch-project#4936)

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>
Naarcha-AWS pushed a commit that referenced this issue Oct 20, 2023
Changing configuration reference line 84 from 'cluster_manager' to 'master' (Issue #4936)

Signed-off-by: Samuel Valdes Gutierrez <valdesgutierrez@gmail.com>
@hdhalter
Copy link
Contributor

Hi @Naarcha-AWS - Looks like this has been fixed: https://opensearch.org/docs/1.3/tuning-your-cluster/index/#cluster-manager-node. OK to close this issue? Thanks!

@BigSamu
Copy link
Contributor

BigSamu commented Nov 30, 2023

[OSCI][DOC] Fixing documentation in v1.3.x for Cluster Creation.md #5256

Hi @hdhalter, yeah this has been fixed in PR #5256, with a successful merge approved by @Naarcha-AWS.

Regards,

Samuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. Sev2 High-medium priority. Upcoming release or incorrect information.
Projects
None yet
Development

No branches or pull requests

5 participants