Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document logging API dependencies #886

Open
dbwiddis opened this issue Jul 15, 2023 · 0 comments
Open

[DOCS] Document logging API dependencies #886

dbwiddis opened this issue Jul 15, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

SDK has transitive dependencies on multiple logging APIs:

It is therefore not possible for us to exclude either logging API in our build. This can be confusing to downstream users, particularly when they see log4j usage in our codebase, but on command line are always greeted with this lovely prefix:

SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

What solution would you like?

Downstream users of SDK should be aware of this constraint so that they can configure their logging appropriately. The developer guide should mention the above constraint and appropriate workarounds.

What alternatives have you considered?

Removing hard dependency on log4j2 API in OpenSearch. I'll probably propose that but it's not backwards compatible so it'll be a 3.x feature. At some point I'll audit the codebase to see if there are any others.

Do you have any additional context?

Relates to #824

@dbwiddis dbwiddis added enhancement New feature or request untriaged documentation Improvements or additions to documentation good first issue Good for newcomers and removed untriaged enhancement New feature or request labels Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant