Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate OUI theme compliance - phase 1 #1471

Closed
9 tasks done
Tracked by #4291 ...
joshuarrrr opened this issue Jun 15, 2023 · 10 comments
Closed
9 tasks done
Tracked by #4291 ...

Validate OUI theme compliance - phase 1 #1471

joshuarrrr opened this issue Jun 15, 2023 · 10 comments
Assignees

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 15, 2023

This is a tracking issue for phase 1 of OUI theme plugin compliance, which will involve changes to OUI typography and color SASS variables (for both dark and light mode). For full details, including dates and tooling, see opensearch-project/OpenSearch-Dashboards#4291

If your plugin has no UI views or components, please add a comment to that effect, and we'll remove the repo from future look and feel update campaigns.

Actions required

  • Acknowledge the issue by adding an assignee who will serve as a point-of-contact
  • Provide screenshots and navigation instructions for important views and screens in your plugin or application. This will assist with both manual and automatic validation of compliance
  • Identify all typographic properties and styles
  • Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
  • Identify all color values, including visualization colors and palettes
  • Create issues to mitigate typographic styles not inherited from OUI components or SASS variables
  • Resolve all mitigation issues
  • Validate and test plugin with updated OUI theme

Priority issues:

Questions?

Add a comment on opensearch-project/OpenSearch-Dashboards#4291

@stephen-crawford
Copy link
Contributor

[Triage] Hi @joshuarrrr, thank you for making this issue for us. Looking at the linked issue I see:

"We expect to ship the updated theme as an experimental/optional theme in the 2.9 release (code freeze July 11, 2023), and to make it the default theme in 2.10 (code freeze August 22, 2023). In order for the UX time to review and approve all plugins, actions should be completed by August 6, 2023."

Can you confirm when you want these tasks completed? Thank you.

@joshuarrrr
Copy link
Member Author

@scrawfor99 Dates may be subject to change, but yes August 6 is the expected deadline.

@stephen-crawford
Copy link
Contributor

Hi @joshuarrrr, thanks for the clarification. We just wanted to check whether we should have it all done by 7/11 and then have it approved by 8/6 or just by 8/6.

@stephen-crawford
Copy link
Contributor

I believe many of these items have been completed by tasks linked off #1531. I will handle correcting the issues but it seems like the typography and graphics have already been checked based on the filing of the other issues #1529 and #1527.

@stephen-crawford
Copy link
Contributor

Waiting on this change: opensearch-project/OpenSearch-Dashboards#4702

@stephen-crawford
Copy link
Contributor

opensearch-project/OpenSearch-Dashboards#4702 is still in progress with some feedback from the OUI team.

@stephen-crawford
Copy link
Contributor

opensearch-project/OpenSearch-Dashboards#4702 is merged, waiting on backport.

@stephen-crawford
Copy link
Contributor

opensearch-project/OpenSearch-Dashboards#4796 is the backport

@stephen-crawford
Copy link
Contributor

Hi @joshuarrrr,

I just finished looking things over.

While validating security dashboards plugin, I noticed that the previous tab on the top bar showing your webpage path seems to auto highlight. See this photo for example:

Screenshot 2023-08-29 at 3 58 01 PM

Note that "Dashboards Ma..." is highlighted. This was without my mouse over the button. Based on the behavior in light mode, it looks like this is intentional, but I am not sure if we want the current color choice.

I also noticed that Security makes use of the grey text instead of the white text that some other areas use:

Screenshot 2023-08-29 at 4 01 33 PM

This is not wrong, since we still use the theme from core, but I did notice it was different.

Everything else looks correct.

Let me know if anything else needs to be done, if not I will close this issue.

@peternied
Copy link
Member

I am considering this validation complete for v2.10 There are separate issues tracking areas where validation didn't succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants