Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all tests from the functional test to the security-dashboard-plugin #1694

Closed
2 tasks
peternied opened this issue Dec 12, 2023 · 2 comments
Closed
2 tasks
Assignees
Labels

Comments

@peternied
Copy link
Member

Description

The security dashboard plugin has tests in its repository for unit, component, and integration testing and there are additional test cases outside the plugin that are located in the opensearch-dashboards-functional-test we should consolidate all tests into the security repo to be sure that the product functionality is working as intended as changed are maded.

Acceptance Criteria

@peternied
Copy link
Member Author

FYI @davidlago Here is an issue to consolidate the testing infra

@peternied peternied self-assigned this Feb 22, 2024
@peternied
Copy link
Member Author

Looked into doing this. The amount of work required doesn't really pay off, since we already run the tests within our CI flow it can create some diamond dependency issues but those are very rare and not worth the headache of duplicating the function test repo.

I don't have guidance for where tests should be authored, IMO it makes sense to keep new tests in our repo unless they use functionality that is part the shared functional test repo codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant