From 163815b88a48d7396a5b92ccc7da0c0e1153aa8d Mon Sep 17 00:00:00 2001 From: Flavian Missi Date: Fri, 18 Oct 2024 11:13:08 +0200 Subject: [PATCH] azurepathfix: don't requeue when azure storage isn't configured --- pkg/operator/azurepathfixcontroller.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/operator/azurepathfixcontroller.go b/pkg/operator/azurepathfixcontroller.go index 777b0c0a5f..7adb9ea0aa 100644 --- a/pkg/operator/azurepathfixcontroller.go +++ b/pkg/operator/azurepathfixcontroller.go @@ -179,11 +179,11 @@ func (c *AzurePathFixController) sync() error { } azureStorage := imageRegistryConfig.Status.Storage.Azure - if azureStorage == nil || len(azureStorage.AccountName) == 0 { - return fmt.Errorf("storage account not yet provisioned") - } - if azureStorage == nil || len(azureStorage.Container) == 0 { - return fmt.Errorf("storage container not yet provisioned") + if azureStorage == nil || len(azureStorage.AccountName) == 0 || len(azureStorage.Container) == 0 { + // no need to reque when azure storage isn't configured. + // this allows customers to use pvc or even emptyDir in azure + // without getting error messages in loop in the operator logs. + return nil } // the move-blobs cmd does not work on Azure Stack Hub. Users on ASH