Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bike pumps #1339

Open
ArathonV opened this issue Sep 8, 2024 · 1 comment
Open

Add bike pumps #1339

ArathonV opened this issue Sep 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ArathonV
Copy link

ArathonV commented Sep 8, 2024

OSM Tag(s)

amenity=bicycle_repair_station; service:bicycle:pump=yes

How would you like this tag to see supported?

As a Preset

Label

Bicycle pump

Aliases

bike pump

Terms

bike pump, pump

Link to OSM Wiki page

https://wiki.openstreetmap.org/wiki/Key:service:bicycle:pump

Status of the Tag

Approved

Usage of the tag

17000

Replaces other Tag?

No response

Regional Tag?

global

Further Information

This tag could be used to indicate a public bike pump.
This can already be done via "bicycle repair tool stand" and selecting a pump, however this is quite unintuitive.
amenity=bicycle_repair_station service:bicycle:pump=yes
I would also suggest adding service:bicycle:tools=no to indicate that this is only a pump and no tools are present, since tools are implied yes by default.

@mnalis
Copy link
Contributor

mnalis commented Sep 10, 2024

amenity=bicycle_repair_station; service:bicycle:pump=yes

That part sounds good to me.

I would also suggest adding service:bicycle:tools=no to indicate that this is only a pump and no tools are present, since tools are implied yes by default.

Hmmm, I don't think that this part is a good idea. Just because there is a pump, does not mean there is nothing else too. better to just omit service:bicycle:tools=* (and other service:bicycle:*=*), so people can later add them or not at their choice.

Also see this previous discussion #1231 (comment):

Looks perfect; although a preset for "bicycle pump" (with amenity=bicycle_repair_station; service:bicycle:pump=yes might be useful as well to counter your first note)

Perhaps @pietervdvn who suggested it (or someone else) has an idea how it could be best implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants