Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【bug】卸载插件后,activityBar的图标不会消失 #78

Open
xiadd opened this issue Aug 1, 2023 · 5 comments
Open

【bug】卸载插件后,activityBar的图标不会消失 #78

xiadd opened this issue Aug 1, 2023 · 5 comments

Comments

@xiadd
Copy link

xiadd commented Aug 1, 2023

没有修改任何代码,看了一下, 好像是 ide-extension-manager 里没有调用uninstall,

@xiadd
Copy link
Author

xiadd commented Aug 7, 2023

@erha19 麻烦有空看一下

@erha19
Copy link
Member

erha19 commented Aug 7, 2023

@xiadd 可以调试看一下,目前插件副作用的卸载依赖这里这段逻辑,如果没调用应该就不会有效果 https://github.com/opensumi/core/blob/b118fa495ecbd84b19fc2658b1664b25f394a852/packages/extension-manager/src/browser/vsx-extension.service.ts#L143

@xiadd
Copy link
Author

xiadd commented Aug 7, 2023

@xiadd 可以调试看一下,目前插件副作用的卸载依赖这里这段逻辑,如果没调用应该就不会有效果 https://github.com/opensumi/core/blob/b118fa495ecbd84b19fc2658b1664b25f394a852/packages/extension-manager/src/browser/vsx-extension.service.ts#L143

我打了个断点,这里是调用到的,插件列表里也显示卸载了,但是侧边栏的icon就是没消失,复现的话就是这个仓库的main分支最新代码,没有修改任何东西

@erha19
Copy link
Member

erha19 commented Aug 7, 2023

@xiadd 这个问题是出现在某个版本之后的吗?还是你的预期效果?

@xiadd
Copy link
Author

xiadd commented Aug 7, 2023

@xiadd 这个问题是出现在某个版本之后的吗?还是你的预期效果?

这个不太确定,我们本地出现这个情况,然后才想在startup里看看到底怎么回事,预期肯定卸载后icon也跟着消失

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants