From 8947227313df79c9a22a0b3e5d143c0eb312fb7c Mon Sep 17 00:00:00 2001 From: Dan Oved Date: Thu, 26 Oct 2023 12:30:08 -0600 Subject: [PATCH] wip on getting list of versions instead --- .../src/delegation/ZoraCreator1155PremintExecutorImpl.sol | 4 ++-- .../src/interfaces/IZoraCreator1155DelegatedCreation.sol | 2 +- .../src/interfaces/IZoraCreator1155PremintExecutor.sol | 2 +- packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol b/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol index 91c63fb87..e76c07ca4 100644 --- a/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol +++ b/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol @@ -218,10 +218,10 @@ contract ZoraCreator1155PremintExecutorImpl is /// @param contractAddress The address of the contract to check /// @return The version of the premint signature that the contract supports. If it doesn't support premint /// returns 0 - function supportedPremintSignatureVersion(address contractAddress) external view returns (string memory) { + function supportedPremintSignatureVersions(address contractAddress) external view returns (string memory) { IZoraCreator1155 creatorContract = IZoraCreator1155(contractAddress); if (creatorContract.supportsInterface(type(IZoraCreator1155DelegatedCreation).interfaceId)) { - return IZoraCreator1155DelegatedCreation(contractAddress).supportedPremintSignatureVersion(); + return IZoraCreator1155DelegatedCreation(contractAddress).supportedPremintSignatureVersions(); } // try get token id for uid 0 - if call fails, we know this didn't support premint diff --git a/packages/1155-contracts/src/interfaces/IZoraCreator1155DelegatedCreation.sol b/packages/1155-contracts/src/interfaces/IZoraCreator1155DelegatedCreation.sol index 23c4a0535..58cb19f25 100644 --- a/packages/1155-contracts/src/interfaces/IZoraCreator1155DelegatedCreation.sol +++ b/packages/1155-contracts/src/interfaces/IZoraCreator1155DelegatedCreation.sol @@ -4,7 +4,7 @@ pragma solidity 0.8.17; interface IZoraCreator1155DelegatedCreation { event CreatorAttribution(bytes32 structHash, string domainName, string version, address creator, bytes signature); - function supportedPremintSignatureVersion() external pure returns (string memory); + function supportedPremintSignatureVersions() external pure returns (string memory); function delegateSetupNewToken( bytes memory premintConfigEncoded, diff --git a/packages/1155-contracts/src/interfaces/IZoraCreator1155PremintExecutor.sol b/packages/1155-contracts/src/interfaces/IZoraCreator1155PremintExecutor.sol index cdbbc957d..f1fc56fec 100644 --- a/packages/1155-contracts/src/interfaces/IZoraCreator1155PremintExecutor.sol +++ b/packages/1155-contracts/src/interfaces/IZoraCreator1155PremintExecutor.sol @@ -94,5 +94,5 @@ interface IZoraCreator1155PremintExecutor is function getContractAddress(ContractCreationConfig calldata contractConfig) external view returns (address); - function supportedPremintSignatureVersion(address contractAddress) external view returns (string memory); + function supportedPremintSignatureVersions(address contractAddress) external view returns (string memory); } diff --git a/packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol b/packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol index 0b2619c2f..fb9c632f5 100644 --- a/packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol +++ b/packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol @@ -752,7 +752,7 @@ contract ZoraCreator1155Impl is return _getImplementation(); } - function supportedPremintSignatureVersion() external pure returns (string memory) { + function supportedPremintSignatureVersions() external pure returns (string memory) { return ZoraCreator1155Attribution.VERSION_2; }