From 3d5e8fa455cc99b5897e50cab91215831027a096 Mon Sep 17 00:00:00 2001 From: rohan-saeed <147135540+rohan-saeed@users.noreply.github.com> Date: Fri, 7 Jun 2024 18:14:53 +0500 Subject: [PATCH] feat!: upgrade mysql to 8.4.0 (#1071) --- changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md | 2 ++ docs/configuration.rst | 2 +- tests/commands/test_images.py | 2 +- tutor/templates/config/defaults.yml | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md diff --git a/changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md b/changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md new file mode 100644 index 0000000000..7191b7ecb3 --- /dev/null +++ b/changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md @@ -0,0 +1,2 @@ +- 💥[Improvement] Upgrade MySQL to 8.4.0 (by @rohansaeed) + The upgrade should be automatic for most users. However, if you are running a third-party MySQL (i.e., RUN_MYSQL=false), you are expected to upgrade manually. Please refer to the third-party provider's documentation for detailed upgrade instructions. Ensuring that your MySQL version is up-to-date is crucial for maintaining compatibility and security. diff --git a/docs/configuration.rst b/docs/configuration.rst index a6c3fc7cbb..928f3ad357 100644 --- a/docs/configuration.rst +++ b/docs/configuration.rst @@ -81,7 +81,7 @@ This configuration parameter defines which MongoDB Docker image to use. .. https://hub.docker.com/_/mysql/tags?page=1&name=8.0 -- ``DOCKER_IMAGE_MYSQL`` (default: ``"docker.io/mysql:8.1.0"``) +- ``DOCKER_IMAGE_MYSQL`` (default: ``"docker.io/mysql:8.4.0"``) This configuration parameter defines which MySQL Docker image to use. diff --git a/tests/commands/test_images.py b/tests/commands/test_images.py index 32ddba885f..22a9072c5e 100644 --- a/tests/commands/test_images.py +++ b/tests/commands/test_images.py @@ -49,7 +49,7 @@ def test_images_pull_all_vendor_images(self, image_pull: Mock) -> None: self.assertIsNone(result.exception) self.assertEqual(0, result.exit_code) # Note: we should update this tag whenever the mysql image is updated - image_pull.assert_called_once_with("docker.io/mysql:8.1.0") + image_pull.assert_called_once_with("docker.io/mysql:8.4.0") def test_images_printtag_image(self) -> None: result = self.invoke(["images", "printtag", "openedx"]) diff --git a/tutor/templates/config/defaults.yml b/tutor/templates/config/defaults.yml index 61df930202..c60e9f0e58 100644 --- a/tutor/templates/config/defaults.yml +++ b/tutor/templates/config/defaults.yml @@ -21,7 +21,7 @@ DOCKER_IMAGE_ELASTICSEARCH: "docker.io/elasticsearch:7.17.13" # https://hub.docker.com/_/mongo/tags DOCKER_IMAGE_MONGODB: "docker.io/mongo:7.0.7" # https://hub.docker.com/_/mysql/tags -DOCKER_IMAGE_MYSQL: "docker.io/mysql:8.1.0" +DOCKER_IMAGE_MYSQL: "docker.io/mysql:8.4.0" DOCKER_IMAGE_PERMISSIONS: "{{ DOCKER_REGISTRY }}overhangio/openedx-permissions:{{ TUTOR_VERSION }}" # https://hub.docker.com/_/redis/tags DOCKER_IMAGE_REDIS: "docker.io/redis:7.2.4"