Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 11.4.1.2 Name-role value #4373

Closed
11 tasks done
Tracked by #4398
tschiebel opened this issue Apr 5, 2024 · 3 comments · Fixed by #4454
Closed
11 tasks done
Tracked by #4398

[a11y] 11.4.1.2 Name-role value #4373

tschiebel opened this issue Apr 5, 2024 · 3 comments · Fixed by #4454

Comments

@tschiebel
Copy link

tschiebel commented Apr 5, 2024

audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV

https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf
https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de

Personal Space

  • Several buttons have been detected on the page that do not have a role assigned.
    image

  • If the elements on the page are sorted, the status of the sorting is only visually represented by arrows. However, this visual representation is a limitation for non-visual users, as they do not receive any information about the current sorting.
    image

  • The button with the "+" does have an accessible name, but this is not meaningful. It would make sense to use the word "Add", for example, to give users a clear description of the function. There is also a problem for non-visual users, as opening the menu is not clearly signaled. It is important that the status of the menu is accessible to all users.
    image

Menu

  • The link "...-Portal" was not correctly marked as a link. The role "Link" is missing, which should be used for the semantically correct labeling of links.

  • The logo (see screenshot) was erroneously labeled as a button although clicking on the element opens a new page in the browser. Instead, the logo should be provided with a link element in order to be semantically correct.
    image

  • All elements of the menu are missing the correct role, either "Button" or "Link".
    image

  • The button with the account data does not have a corresponding role. In addition, the labeling is too long and difficult to understand. It is also unclear which view of the menu users are currently in.
    image

Edit shared Link

  • The "Expiry date" and "Date" buttons have no role.
    image

Spaces

  • Both the "Spaces" heading (button) and the "Space" buttons do not have a role.
    image

Manage Account

  • Neither the "Add account" button nor the "Account" button have a role.
    image

Image Viewer

  • None of the items in the "More options" menu have a role.
    image
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 17, 2024

Pending to check. Are roles really a mobile concept? or only web?

@JuancaG05 JuancaG05 added this to the Accessibility milestone May 3, 2024
@Aitorbp Aitorbp linked a pull request Aug 7, 2024 that will close this issue
4 tasks
@Aitorbp Aitorbp removed a link to a pull request Aug 7, 2024
4 tasks
@Aitorbp Aitorbp self-assigned this Aug 8, 2024
@Aitorbp
Copy link
Collaborator

Aitorbp commented Aug 13, 2024

Menu

  • The link "...-Portal" was not correctly marked as a link
    correctly. The role "Link" is missing, which should be used for the semantically correct
    should be used for the semantically correct labeling of links.
  • The logo (see screenshot) was erroneously labeled as a button
    although clicking on the element opens a new page in the browser.
    opens a new page in the browser. Instead, the logo should be provided with a link element
    in order to be semantically correct.
    image
  • All elements of the menu are missing the correct role, either
    "Button" or "Link".
    image

The elements of the Menu have now a role.

  • The button with the account data does not have a corresponding role.
    In addition, the labeling is too long and difficult to understand. It is
    It is also unclear which view of the menu users are currently in.
    image

This element is not going to be changed due to the current behaviour is the following: when you click in this element the talkback said Header, so it is enough information to know we are in the header of the drawer. In any case, this element doesn't have a functionality, it is just information that the user can see.

Edit shared Link

  • The "Expiry date" and "Date" buttons have no role.
    image

The date text that appears when you choose a date in the date picker has been assigned a role. In any case, related elements have been labeled with the corresponding switches in this pr #4448 related to this issue #4363.

Spaces

  • Both the "Spaces" heading (button) and the "Space" buttons
    do not have a role.
    image

About the Spaces heading, at the moment we are going to set the talkback in this element like "Search button" in all toolbars.

This report is contradictory with another accessibility report #4362 we had where we were asked to put the Space title as a heading and now they tell us to give it the role of a button. I think both labels should not coexist, either it is a button or it is a heading.

But you have to know there is a issue #4452 opened to discuss about the behavior of the Toolbar and the SearchView. The proposal is divided the title and the search icon in differents elements, so when only when the search icon is clicked the search view will be opened.

Manage Account

  • Neither the "Add account" button nor the "Account" button have a role.
    have a role.
    image

A role has been assigned to the elements of this view.

Image Viewer

  • None of the items in the "More options" menu have a role.
    image

A role has been assigned to the elements of this view.

@Aitorbp
Copy link
Collaborator

Aitorbp commented Aug 22, 2024

audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV

https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de

Personal Space

  • Several buttons have been detected on the page that do not have a role
    assigned.
    image

A role has been assigned to the elements of this view.

  • If the elements on the page are sorted, the status of the sorting is only visually
    sorting status is only visually represented by arrows. However, this visual representation
    visual representation is a limitation for non-visual users, as they do not receive any
    information about the current sorting.
    image

A role has been assigned to the elements of this view.

  • The button with the "+" does have an accessible name,
    but this is not meaningful. It would make sense to use the word "Add" as an accessible
    the word "Add", for example, to give users a clear description of the function.
    clear description of the function.
    There is also a problem for non-visual users, as opening the menu is not
    opening the menu is not clearly signaled. It is important that the status
    of the menu is accessible to all users.
    image

A role has been assigned to the elements of this view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants