forked from PatWie/CppNumericalSolvers
-
Notifications
You must be signed in to change notification settings - Fork 0
/
lint.py
executable file
·313 lines (250 loc) · 11.6 KB
/
lint.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
#!/usr/bin/env python
import re
import sys
import glob
import codecs
import unicodedata
_settings_extensions = set(['cc', 'h', 'cpp', 'cu', 'cuh', 'hpp', 'cxx'])
_settings_lineWidth = 150
_settings_extraInfo = True
_settings_checks = {"studentname": False,
"space indentation": True,
"line width": True,
"space before {": True,
"symbol whitespace": True,
"trailing whitespace": True,
"function definition whitespace": True,
"camelCase": True,
"endif comment": True,
"global namespaces": True,
"multiple empty lines": True}
regExCache = {}
ERROR_COUNTER = 0
class RegExMatcher(object):
def __init__(self, matchstring):
self.matchstring = matchstring
def match(self, regex_expr):
if regex_expr not in regExCache:
regExCache[regex_expr] = re.compile(regex_expr)
self.ans = regExCache[regex_expr].match(self.matchstring)
return bool(self.ans)
def search(self, regex_expr):
if regex_expr not in regExCache:
regExCache[regex_expr] = re.compile(regex_expr)
self.ans = regExCache[regex_expr].search(self.matchstring)
return bool(self.ans)
def findall(self, regex_expr):
if regex_expr not in regExCache:
regExCache[regex_expr] = re.compile(regex_expr)
self.ans = regExCache[regex_expr].finditer(self.matchstring)
return bool(self.ans)
def all(self):
return self.ans
def span(self):
return self.ans.span()
def line_width(line):
if isinstance(line, unicode):
width = 0
for uc in unicodedata.normalize('NFC', line):
if unicodedata.east_asian_width(uc) in ('W', 'F'):
width += 2
elif not unicodedata.combining(uc):
width += 1
return width
else:
return len(line)
def print_error(filename, linenum, category, message, level=0, line="", char=-1):
global ERROR_COUNTER
ERROR_COUNTER = ERROR_COUNTER + 1
# level 0: warning
# level 1: error
if level == 0:
sys.stderr.write('(line %s): \033[91m[%s]\033[0m %s\n' % (linenum, category, message))
elif level == 1:
sys.stderr.write('(line %s): \033[91m[%s]\033[0m %s\n' % (linenum, category, message))
else:
sys.stderr.write('(line %s): [%14s] %s\n' % (linenum, category, message))
if _settings_extraInfo:
if char != -1:
sys.stderr.write('%s %s\n' % (' ' * (10 + 3 + 3 + len(str(linenum))), line))
sys.stderr.write('%s \033[96m%s%s\033[0m\n' % (' ' * (10 + 3 + 3 + len(str(linenum))), '-' * char, '^'))
def process_braces(filename, lines, error):
ident = []
for line in range(len(lines)):
for char in range(len(lines[line])):
if lines[line][char] == '{':
fullstr = lines[line]
startwhites = len(fullstr) - len(fullstr.lstrip())
ident.append((startwhites, line, char + 2))
if lines[line][char] == '}':
fullstr = lines[line]
startwhites = len(fullstr) - len(fullstr.lstrip())
if len(ident) == 0:
msg = 'bracket in line %i at pos %i has no related opening' % (line, char)
error(filename, line, 'ident', msg, 1, lines[line], char)
break
if(ident[len(ident) - 1][1] != line):
if(ident[len(ident) - 1][0] != startwhites):
msg = 'indentation of bracket in line %i does not match indentation of bracket in line %i'
msg = msg % (line, ident[len(ident) - 1][1])
error(filename, line, 'ident', msg)
del ident[-1]
def process_clean_file_line(filename, file_extension, lines, error, linenum, raw):
line = lines[linenum]
rline = raw[linenum]
# check if line is comment
m = RegExMatcher(line)
if m.match(r'\s*//'):
return
if _settings_checks["space before {"]:
m = RegExMatcher(line)
if m.search(r'\S\{'):
if not line[m.span()[1] - 2] == '"':
error(filename, linenum, 'braces', 'found no space before {', 1, rline, m.span()[1] - 1)
if _settings_checks["symbol whitespace"]:
m = RegExMatcher(line)
if m.search(r'^([^"]|"[^"]*")*?([,=])\S'): # do not look inside quoted strings
# exclude cases ==
if not line[m.span()[1] - 2:m.span()[1]] == "==":
error(filename, linenum, 'whitespace', 'no whitespace after symbol', 1, rline, m.span()[1] - 2)
if _settings_checks["function definition whitespace"]:
m = RegExMatcher(line)
if m.search(r'[^(for)(while)(if)(else)\n&\*/\+\-\|=\,]+\s+\('):
# exclude special case with only whitespaces
mm = RegExMatcher(line[0:m.span()[1]])
if not mm.search(r'^\s+\('):
if not mm.search(r'return\s\(') and not mm.search(r'<\s\('):
error(filename, linenum, 'whitespace', 'found whitespace before (', 1, rline, m.span()[1] - 1)
if _settings_checks["camelCase"]:
m = RegExMatcher(line)
if m.search(r'\w+\s*\s[A-Z]+\w*\(.*\{'):
error(filename, linenum, 'capitalization', 'found function without camelCase', 1, rline, m.span()[1] - 1)
if _settings_checks["global namespaces"]:
m = RegExMatcher(line)
if m.search(r'using\s+namespace'):
error(filename, linenum, 'style', 'do not use global namespaces', 1, rline, m.span()[1] - 1)
def process_file_line(filename, file_extension, lines, error, linenum):
line = lines[linenum]
# check if line is comment
m = RegExMatcher(line)
if m.match(r'\s*//'):
return
if _settings_checks["space indentation"]:
m = RegExMatcher(line)
if m.search('\t'):
error(filename, linenum, 'tab', 'use spaces instead of tabs', 1, line, m.span()[1] - 1)
if _settings_checks["line width"]:
if line_width(line) > _settings_lineWidth:
error(filename, linenum, 'line_length', 'lines should be <= %i characters long' % _settings_lineWidth)
if _settings_checks["trailing whitespace"]:
m = RegExMatcher(line)
if m.search(r'\s+$'):
error(filename, linenum, 'whitespace', 'found trailing whitespace', 1, line, m.span()[1] - 1)
if _settings_checks["endif comment"]:
m = RegExMatcher(line)
if m.search(r'#endif\s*$'):
error(filename, linenum, 'comment', 'found endif without comment', 1, line, m.span()[1] - 1)
def process_clean_file_content(filename, file_extension, lines, ignore_lines, error, raw):
lines = (['// marker so line numbers and indices both start at 1'] + lines +
['// marker so line numbers end in a known way'])
raw = (['// marker so line numbers and indices both start at 1'] + raw +
['// marker so line numbers end in a known way'])
for line in range(len(lines)):
if line not in ignore_lines:
process_clean_file_line(filename, file_extension, lines, error, line, raw)
def process_file_content(filename, file_extension, lines, ignore_lines, error):
# test if file is ending with empty lines
empty_lines = 0
for i in range(len(lines)):
if lines[len(lines) - i - 1] == "":
empty_lines = empty_lines + 1
else:
break
if empty_lines == 0:
error(filename, len(lines) - empty_lines, 'empty', 'file ends without empty lines')
lines = (['// marker so line numbers and indices both start at 1'] + lines +
['// marker so line numbers end in a known way'])
for line in range(len(lines)):
if line not in ignore_lines:
process_file_line(filename, file_extension, lines, error, line)
process_braces(filename, lines, error)
# http://stackoverflow.com/questions/241327/python-snippet-to-remove-c-and-c-comments
def comment_remover(text):
def get_newline_chars(str_in):
return "" + ("\n" * str_in.count('\n'))
def replacer(match):
s = match.group(0)
if s.startswith('/'): # Matched string is //...EOL or /*...*/ ==> Blot out all non-newline chars
return "@#@" + get_newline_chars(s)
else: # Matched string is '...' or "..." ==> Keep unchanged
return s
pattern = re.compile(r'//.*?$|/\*.*?\*/|\'(?:\\.|[^\\\'])*\'|"(?:\\.|[^\\"])*"',
re.DOTALL | re.MULTILINE)
raw = re.sub(pattern, replacer, text)
raw = re.sub(r'[ ]*@#@', '', raw)
return raw
def process_file(filename):
error_collection = []
def error_handler(filename, linenum, category, message, level=0, line="", char=-1):
error_collection.append((filename, linenum, category, message, level, line, char))
file_extension = filename[filename.rfind('.') + 1:]
if file_extension not in _settings_extensions:
return
raw_source = codecs.open(filename, 'r', 'utf8', 'replace').read()
lines = raw_source.split('\n')
lf_lines = []
crlf_lines = []
for linenum in range(len(lines) - 1):
if lines[linenum].endswith('\r'):
lines[linenum] = lines[linenum].rstrip('\r')
crlf_lines.append(linenum + 1)
else:
lf_lines.append(linenum + 1)
# check each line
if lf_lines and crlf_lines:
for linenum in crlf_lines:
error_handler(filename, linenum, 'newline', 'use \\n here')
# check authorname
if _settings_checks["studentname"]:
m = RegExMatcher(lines[0])
if not m.match(r'// @student:\s\w+[\s*\w*]*'):
msg = 'failed finding name of student in first line. Correct: "// @student: foo"'
error_handler(filename, 1, 'content', msg, 1)
# check double newline
if _settings_checks["multiple empty lines"]:
m = RegExMatcher(raw_source)
if m.findall(r'(\n[ ]*){3,}'):
for mm in m.all():
msg = 'too many empty new lines (count %i)'
msg = msg % (-2 + len(raw_source[mm.span()[0]:mm.span()[1]].split('\n')))
error_handler(filename, len(raw_source[:mm.span()[1]].split('\n')) - 1, 'empty', msg, 1)
# get lines to ignore
ignore_lines = []
pattern = re.compile(r'nolintnextline')
m.findall(pattern)
for mm in m.all():
ignore_lines.append(len(raw_source[:mm.span()[1]].split('\n')) + 1)
pattern = re.compile(r'nolint')
m.findall(pattern)
for mm in m.all():
ignore_lines.append(len(raw_source[:mm.span()[1]].split('\n')))
process_file_content(filename, file_extension, lines, ignore_lines, error_handler)
# clean lines (remove multi line comment)
lines = raw_source.split('\n')
clines = comment_remover(raw_source).split('\n')
process_clean_file_content(filename, file_extension, clines, ignore_lines, error_handler, lines)
if len(error_collection):
sys.stderr.write('\033[1m\033[93m%10s\033[0m:\n' % (filename))
for e in error_collection:
print_error(*e)
if __name__ == '__main__':
filenames = glob.glob("src/examples/*.cpp") + glob.glob("include/cppoptlib/*/*.h")
print("start linting")
print(filenames)
for filename in filenames:
process_file(filename)
sys.stderr.write("\n\n")
if ERROR_COUNTER == 0:
sys.exit(ERROR_COUNTER)
else:
sys.exit(ERROR_COUNTER)