From c36aaaebd91fe7c20089bf9af0aef2e02a727f66 Mon Sep 17 00:00:00 2001 From: Gilad Gray Date: Tue, 29 May 2018 16:07:08 -0700 Subject: [PATCH] use default generics for ContextMenuTarget & HotkeysTarget fixes compiler error with latest types (due to third type param in ComponentLifecycle) --- packages/core/src/components/context-menu/contextMenuTarget.tsx | 2 +- packages/core/src/components/hotkeys/hotkeysTarget.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/context-menu/contextMenuTarget.tsx b/packages/core/src/components/context-menu/contextMenuTarget.tsx index ca2a7473ee..04260822c2 100644 --- a/packages/core/src/components/context-menu/contextMenuTarget.tsx +++ b/packages/core/src/components/context-menu/contextMenuTarget.tsx @@ -12,7 +12,7 @@ import { isFunction, safeInvoke } from "../../common/utils"; import { isDarkTheme } from "../../common/utils/isDarkTheme"; import * as ContextMenu from "./contextMenu"; -export interface IContextMenuTarget extends React.Component { +export interface IContextMenuTarget extends React.Component { renderContextMenu(e: React.MouseEvent): JSX.Element | undefined; onContextMenuClose?(): void; } diff --git a/packages/core/src/components/hotkeys/hotkeysTarget.tsx b/packages/core/src/components/hotkeys/hotkeysTarget.tsx index f32b1ebcc4..f85bcc63ef 100644 --- a/packages/core/src/components/hotkeys/hotkeysTarget.tsx +++ b/packages/core/src/components/hotkeys/hotkeysTarget.tsx @@ -10,7 +10,7 @@ import { isFunction, safeInvoke } from "../../common/utils"; import { IHotkeysProps } from "./hotkeys"; import { HotkeyScope, HotkeysEvents } from "./hotkeysEvents"; -export interface IHotkeysTarget extends React.Component, React.ComponentLifecycle { +export interface IHotkeysTarget extends React.Component { /** @internal */ globalHotkeysEvents?: HotkeysEvents;