Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KSS an optional dependency #31

Open
adidahiya opened this issue Apr 21, 2017 · 3 comments
Open

Make KSS an optional dependency #31

adidahiya opened this issue Apr 21, 2017 · 3 comments

Comments

@adidahiya
Copy link
Contributor

I want to use documentalist on a TypeScript-only project. I don't want to download kss and its dependencies.

@giladgray
Copy link
Contributor

@adidahiya seems reasonable 👍 . i'd argue we should do the same for typescript. the only plugin that's really required is markdown.

@suchanlee
Copy link

suchanlee commented Jul 22, 2019

bump on this issue. Our project uses node 12 and the latest version of kss currently brings in an older version of nunjucks which requires node to be of version >= 6.9.0 <= 11.1.0.

kss updated its dependency to bringing the latest version of nunjucks which removes the version upperbound but hasn't yet cut a release

@adidahiya
Copy link
Contributor Author

@suchanlee thanks for the heads up... after looking at optionalDependencies some more, I don't think this is actually what we want for @documentalist/compiler. I've never seen this type of dependency used seamlessly in practice... I think a more appropriate solution would be to split the plugins out into different packages (like @documentalist/plugin-kss) and use regular dependencies. However, this would be a breaking change. Since Node 12 is not an urgent priority for us (until it enters active LTS on 2019-10-22), I would advise staying on Node 10 for now and waiting for kss to cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants