From a419c42358a2a26b4a42b044b95f6c9a57c5e6f9 Mon Sep 17 00:00:00 2001 From: Paul-Elliot Date: Thu, 12 Sep 2024 15:36:28 +0200 Subject: [PATCH] CI: fix invalid name for artifact Namely: ``` Error: The artifact name is not valid: archives-linux/amd64-x86_64. Contains the following character: Forward slash / Invalid characters include: Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash / These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems. ``` --- .github/workflows/build.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c2d7a53..3a1e057 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -75,7 +75,7 @@ jobs: # if: startsWith(github.ref, 'refs/tags/') uses: actions/upload-artifact@v4 with: - name: archives-${{ matrix.platform.name }}-${{ matrix.platform.target_arch }} + name: archives-linux-${{ matrix.platform.target_arch }} path: new_release/* mac-build: @@ -84,7 +84,7 @@ jobs: matrix: config: - { os: "macos-13", arch: "x86_64" } - - { os: "macos-14", arch: "xarm64" } + - { os: "macos-14", arch: "arm64" } ocaml-compiler: - 4.14.x runs-on: ${{ matrix.config.os }} @@ -112,7 +112,7 @@ jobs: mkdir -p new_release; export OUTPUT=$PWD/new_release; export TARGETOS=macos; - export TARGETARCH={{ matrix.config.arch }}; + export TARGETARCH=${{ matrix.config.arch }}; export VERSION=$GITHUB_REF_NAME; opam exec -- bash release/release.sh