Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPM-MB: Consider refactoring the ElectionDataProvider and ElectionProvider traits and remove self-weighting in key methods #6136

Open
gpestana opened this issue Oct 18, 2024 · 1 comment
Open

EPM-MB: Consider refactoring the ElectionDataProvider and ElectionProvider traits and remove self-weighting in key methods #6136

gpestana opened this issue Oct 18, 2024 · 1 comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.

Comments

@gpestana
Copy link
Contributor

Multiple trait methods of trait ElectionProvider and trait ElectionDataProvider are self-weighting (e.g. ElectionProvider::elect()). Consider removing that implicit assumption and return the weight of the computation to be registered by the caller.

Related to #6034 (comment)
@gpestana gpestana added the T2-pallets This PR/Issue is related to a particular pallet. label Oct 18, 2024
@gpestana gpestana changed the title EPM-MB: Consider refactoring the ElectionDataProvider and ElectionProvider traits to remove the self-weighting methods EPM-MB: Consider refactoring the ElectionDataProvider and ElectionProvider traits and remove self-weighting in key methods Oct 18, 2024
@gpestana gpestana mentioned this issue Oct 18, 2024
Open
1 task
@PolkadotDom
Copy link
Contributor

Could pick this up, but what's the status on this you think @gpestana? Should I wait until #6034 and #6213 are in or is this ready for implementation now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
AHM
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpestana @PolkadotDom