[feature] self upgrading release binary #50

kskarthik · 2024-04-07T06:18:14Z

The idea is to have similar feature to deno upgrade & bun upgrade in which the user can upgrade the existing binary using a cli flag.

This will be a useful feature for many users whose distributions which always do not ship with latest versions of the cli

I wish to work on this patch if we can agree on implementing such feature.

The text was updated successfully, but these errors were encountered:

speatzle · 2024-04-07T15:07:28Z

I do not know of any distributions that ships go-passbolt-cli in their repositories, which is why i always planned to provide my own deb and rpm repositories for easy updates but got stalled due to my limited time and low demand.

Would having generic deb and rpm repositories solve your Issue? I think building an Updater from Scratch would be quite complex since it would also need to handle things like man pages and shell completions. The security implications would also have to be considered.

kskarthik · 2024-04-07T17:02:34Z

i have initially found this lib which can do the heavy lifing (also includes security aspects like checksum verification) https://github.com/creativeprojects/go-selfupdate

Would having generic deb and rpm repositories solve your Issue?

yes, it would. But it also implies user should add custom repos to their system

speatzle · 2024-04-08T12:39:00Z

I don't see how that library can update additional files like man pages or shell completions (maybe i missed it?). Also if anything goes wrong and can't start it anymore there is no possibility to downgrade again. I generally dislike the Windows Style Self updating.

I don't see adding custom repositories as such a big deal (you also have to do that if you are installing the passbolt server). go-passbolt-cli Simply is not big enough to be included in distros.

I tried to avoid having to add custom repos by looking into packaging the CLI as a Flatpak instead but their CLI Support has "Issues" we would have to work around flatpak/flatpak#1188 .

kskarthik · 2024-04-08T16:14:08Z

I don't see how that library can update additional files like man pages or shell completions (maybe i missed it?). Also if anything goes wrong and can't start it anymore there is no possibility to downgrade again. I generally dislike the Windows Style Self updating.

Yes, The lib i shared does not handle man pages & shell completions.

I tried to avoid having to add custom repos by looking into packaging the CLI as a Flatpak instead but their CLI Support has "Issues" we would have to work around flatpak/flatpak#1188 .

yes, flatpaks are not ideal for CLIs. We have to add an alias & no support for man pages AFAIK

speatzle · 2024-06-06T13:51:05Z

In the meantime, go-passbolt-cli has been added as a nixpkg https://search.nixos.org/packages?channel=24.05&show=go-passbolt-cli&from=0&size=50&sort=relevance&type=packages&query=go-passbolt-cli

kskarthik · 2024-06-16T13:01:12Z

I have also packaged for opensuse tumbleweed https://build.opensuse.org/request/show/1181068

It takes a few days to land in the main repositories!

speatzle · 2024-06-16T20:47:56Z

I have also packaged for opensuse tumbleweed https://build.opensuse.org/request/show/1181068

Cool, i will add that to the Readme once it has been released

kskarthik · 2024-06-17T05:20:59Z

Sure, i will let you know

kskarthik · 2024-07-01T10:42:15Z

@speatzle Now accepted to opensuse tumbleweed! https://build.opensuse.org/package/show/openSUSE:Factory/go-passbolt-cli

url: https://software.opensuse.org/package/go-passbolt-cli

kskarthik · 2024-07-01T16:40:52Z

It might also reflect here https://repology.org/project/go:passbolt-cli/versions shortly

speatzle · 2024-07-02T09:37:43Z

Cool, i will give it a spin this weekend.

kskarthik · 2024-07-04T09:51:21Z

btw is this project still community driven or made official ? since i set the disclaimer in pkg info as well

❯ zypper info go-passbolt-cli
Loading repository data...
Reading installed packages...


Information for package go-passbolt-cli:
----------------------------------------
Repository     : Main Repository (OSS)
Name           : go-passbolt-cli
Version        : 0.3.1-1.1
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 18.5 MiB
Installed      : No
Status         : not installed
Source package : go-passbolt-cli-0.3.1-1.1.src
Upstream URL   : https://github.com/passbolt/go-passbolt-cli
Summary        : A CLI tool to interact with Passbolt
Description    :
    This package provides a CLI tool to interact with Passbolt, An Open
    Source Password Manager for Teams

    Passbolt Website: https://www.passbolt.com/

    This project is community driven and not associated with Passbolt
    SA

speatzle · 2024-07-04T12:00:54Z

Yes, this Project is still Community Driven.

speatzle · 2024-07-19T13:21:47Z

Hey @kskarthik
Sorry for the delay. I finally managed to setup a tumbleweed VM (the first few attempts ended in emergency mode due to broken virtio drivers...) and Test the Package.

It Seems to work well but both shell completions and man pages seem to be missing making it hard to use, could you add those to the package?

You can see how to generate them here: https://github.com/passbolt/go-passbolt-cli/blob/main/.github/workflows/.release.yml

kskarthik · 2024-07-19T16:20:57Z

Sure, I will

kskarthik · 2024-07-20T12:11:50Z

just added shell completions & man page support https://build.opensuse.org/package/rdiff/security:privacy/go-passbolt-cli?opackage=go-passbolt-cli&oproject=openSUSE%3AFactory&rev=4

Will reflect in tumbleweed in a few days

speatzle · 2024-07-24T09:00:09Z

I upgraded the package and the man pages work now, it also installed go-passbolt-cli-bash-completions during the upgrade but i can't get the completions to work. Do i need to enable them manually?

kskarthik · 2024-07-24T10:00:45Z

do you have the bash-completion package installed ?

zypper info bash-completion ?

speatzle · 2024-07-24T10:33:53Z

Yes, it was installed automatically:

slt@localhost:~> zypper search passbolt
Loading repository data...
Reading installed packages...

S  | Name                            | Summary                              | Type
---+---------------------------------+--------------------------------------+--------
i+ | go-passbolt-cli                 | A CLI tool to interact with Passbolt | package
i  | go-passbolt-cli-bash-completion | Bash Completion for go-passbolt-cli  | package
   | go-passbolt-cli-fish-completion | Fish Completion for go-passbolt-cli  | package
   | go-passbolt-cli-zsh-completion  | ZSH Completion for go-passbolt-cli   | package
slt@localhost:~> zypper info bash-completion
Loading repository data...
Reading installed packages...


Information for package bash-completion:
----------------------------------------
Repository     : Main Repository (OSS)
Name           : bash-completion
Version        : 2.12.0-2.2
Arch           : noarch
Vendor         : openSUSE
Installed Size : 1003.5 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : bash-completion-2.12.0-2.2.src
Upstream URL   : https://github.com/scop/bash-completion/
Summary        : Programmable Completion for Bash
Description    : 




    bash-completion is a collection of shell functions that take advantage
    of the programmable completion feature of Bash 2.04 and later.

slt@localhost:~> zypper info go-passbolt-cli-bash-completion
Loading repository data...
Reading installed packages...


Information for package go-passbolt-cli-bash-completion:
--------------------------------------------------------
Repository     : Main Repository (OSS)
Name           : go-passbolt-cli-bash-completion
Version        : 0.3.1-2.1
Arch           : noarch
Vendor         : openSUSE
Installed Size : 69.1 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : go-passbolt-cli-0.3.1-2.1.src
Upstream URL   : https://github.com/passbolt/go-passbolt-cli
Summary        : Bash Completion for go-passbolt-cli
Description    : 
    The official bash completion script for go-passbolt-cli, generated during the build.

kskarthik · 2024-07-24T13:04:14Z

ok, https://build.opensuse.org/projects/openSUSE:Factory/packages/go-passbolt-cli/files/go-passbolt-cli.spec?expand=1 L94 is where the bash completions go

kskarthik · 2024-07-25T05:32:10Z

i can see the bash completions listed. do you find any anomaly?

usr/share/man/man1/passbolt.1.gz
/usr/share/bash-completion/completions/go-passbolt-cli

kskarthik · 2024-07-25T05:39:52Z

should the completions match the binary name ?

speatzle · 2024-07-25T12:43:18Z

Moving to file to match the binary name and restarting bash fixed it for me

slt@localhost:~> sudo mv /usr/share/bash-completion/completions/go-passbolt-cli  /usr/share/bash-completion/completions/passbolt
[sudo] password for root: 
slt@localhost:~> bash
slt@localhost:~> passbolt 
configure  create     delete     export     get        help       list       move       share      update     verify     
slt@localhost:~> passbolt list 
folder    group     resource  user      
slt@localhost:~> passbolt list resource

kskarthik · 2024-07-25T15:04:41Z

ok, i will correct it upstream too

speatzle mentioned this issue Aug 13, 2024

Update README.md Install Section #61

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] self upgrading release binary #50

[feature] self upgrading release binary #50

kskarthik commented Apr 7, 2024 •

edited

Loading

speatzle commented Apr 7, 2024

kskarthik commented Apr 7, 2024 •

edited

Loading

speatzle commented Apr 8, 2024

kskarthik commented Apr 8, 2024

speatzle commented Jun 6, 2024

kskarthik commented Jun 16, 2024

speatzle commented Jun 16, 2024

kskarthik commented Jun 17, 2024

kskarthik commented Jul 1, 2024 •

edited

Loading

kskarthik commented Jul 1, 2024

speatzle commented Jul 2, 2024

kskarthik commented Jul 4, 2024 •

edited

Loading

speatzle commented Jul 4, 2024

speatzle commented Jul 19, 2024 •

edited

Loading

kskarthik commented Jul 19, 2024

kskarthik commented Jul 20, 2024

speatzle commented Jul 24, 2024

kskarthik commented Jul 24, 2024 •

edited

Loading

speatzle commented Jul 24, 2024

kskarthik commented Jul 24, 2024

kskarthik commented Jul 25, 2024

kskarthik commented Jul 25, 2024

speatzle commented Jul 25, 2024 •

edited

Loading

kskarthik commented Jul 25, 2024

[feature] self upgrading release binary #50

[feature] self upgrading release binary #50

Comments

kskarthik commented Apr 7, 2024 • edited Loading

speatzle commented Apr 7, 2024

kskarthik commented Apr 7, 2024 • edited Loading

speatzle commented Apr 8, 2024

kskarthik commented Apr 8, 2024

speatzle commented Jun 6, 2024

kskarthik commented Jun 16, 2024

speatzle commented Jun 16, 2024

kskarthik commented Jun 17, 2024

kskarthik commented Jul 1, 2024 • edited Loading

kskarthik commented Jul 1, 2024

speatzle commented Jul 2, 2024

kskarthik commented Jul 4, 2024 • edited Loading

speatzle commented Jul 4, 2024

speatzle commented Jul 19, 2024 • edited Loading

kskarthik commented Jul 19, 2024

kskarthik commented Jul 20, 2024

speatzle commented Jul 24, 2024

kskarthik commented Jul 24, 2024 • edited Loading

speatzle commented Jul 24, 2024

kskarthik commented Jul 24, 2024

kskarthik commented Jul 25, 2024

kskarthik commented Jul 25, 2024

speatzle commented Jul 25, 2024 • edited Loading

kskarthik commented Jul 25, 2024

kskarthik commented Apr 7, 2024 •

edited

Loading

kskarthik commented Apr 7, 2024 •

edited

Loading

kskarthik commented Jul 1, 2024 •

edited

Loading

kskarthik commented Jul 4, 2024 •

edited

Loading

speatzle commented Jul 19, 2024 •

edited

Loading

kskarthik commented Jul 24, 2024 •

edited

Loading

speatzle commented Jul 25, 2024 •

edited

Loading