Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script broken since Wikipedia update #28

Open
sboli opened this issue Jul 24, 2024 · 3 comments
Open

Script broken since Wikipedia update #28

sboli opened this issue Jul 24, 2024 · 3 comments

Comments

@sboli
Copy link

sboli commented Jul 24, 2024

Hello,

First of all, thanks for this package.

Apparently Wikipedia updated their html, so the script fetch.js is not longer working.

@BlueMesaDev
Copy link

I've tried to push a bugfix branch for this, but don't seem to have permission. Not sure what to do about that! Might not be the right way to do it.

If anyone's bothered, the issue is that Wikipedia used to store the National/International data in an H2 tag, and the country information in an H4 tag. This has been changed to an H2 and H4 inside a DIV.

The file below is a JS file (renamed as text) which you can use to generate the file again.

fetch.txt

If someone can point me in the correct direction of how to push a branch, I'll do that and then raise a PR.

@cavoq
Copy link

cavoq commented Sep 8, 2024

Fixed with some cleanups, see #29.

Use this workflow in the future:

  1. Fork the repo
  2. Create a branch for the desired changes
  3. Push changes to that branch and create a pull request to the original repository
  4. Sync with your master branch and delete branch for changes after the pull request got accepted.

@BlueMesaDev
Copy link

That's great. Didn't realise that's how it worked.

Thanks for the pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants