Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building v2.1.1 on modern hardware/OS #73

Open
cowlibob opened this issue Oct 20, 2018 · 5 comments
Open

Building v2.1.1 on modern hardware/OS #73

cowlibob opened this issue Oct 20, 2018 · 5 comments

Comments

@cowlibob
Copy link

cowlibob commented Oct 20, 2018

I would create a pull request, but there's no suitable branch to target.

Using macOS 10.14 on a new laptop, I had to back port the rake changes for CFLAGS, to exclude i386.
I would be grateful if you could create a 2.1-stable branch from the 2.1.1 tag and merge my changes in, to release v2.1.2 gem.

2.1-stable

Thanks in advance!

@cowlibob cowlibob changed the title Building v2.1.1 on modern hardware Building v2.1.1 on modern hardware/OS Oct 20, 2018
@johanns
Copy link
Collaborator

johanns commented Oct 20, 2018

Please create a pull request and we’ll review it.

@cowlibob
Copy link
Author

cowlibob commented Oct 22, 2018

Hi @johanns , I'd love to, but you don't have a suitable branch to issue a pull request against.

I don't think I can create a pull request on a tag (v2.1.1) so you'll need to create a branch on your repo from https://github.com/pbhogan/scrypt/tree/v2.1.1 first.

I'm happy to be corrected if there is a way.

@cowlibob
Copy link
Author

After further work, it's worth noting that this may be related to using a newer ruby impl. I was attempting to build alongside ruby 2.5.2, while ruby 2.1.2p95 installs/builds the gem without issue.

You may want to close this issue @johanns .

@romonsalve
Copy link

romonsalve commented Oct 23, 2018

It is possible for a 2.1.2 release with the patch like in 3.0.6.?
I'm having the same issue using ruby 2.3.3 with RVM on fresh Mojave install

Update:
Like a workaround, I'm trying to build the gem but the error
"No such file or directory @ rb_sysopen - /Users/myuser/.ssh/gem-private_key.pem" It's displayed.
Do I need a ssh key to bundle locally?

Update 2:
If someone has the same problem, removing the -arch i386 flags from Rake files from the root and inside ext/scrypt and building and installing locally do the trick

@mcauser
Copy link

mcauser commented Jul 20, 2020

See #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants