Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertions cause forced exit after any MapNode or SkyNode is destroyed. #31

Open
AnyOldName3 opened this issue May 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@AnyOldName3
Copy link
Contributor

rocky::MapNode, rocky::SkyNode and possibly other classes copy the InstanceVSG object they're constructed with, and when they're destroyed, so is their copy of the instance. However, when an instance is destroyed, it sets rocky::Instance::_global_status to GeneralError, and as that's static, it means Instance::status() will return a failed status for all instances, and ROCKY_HARD_ASSERT_STATUS will self-destruct.

Either these nodes shouldn't be copying the instance, or the instance status shouldn't be static so the destroyed instances don't pollute the surviving ones.

@gwaldron gwaldron added the bug Something isn't working label May 31, 2024
@gwaldron gwaldron self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants