New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`code-coverage` workflow will always generate badges #186

Open

averissimo opened this issue Feb 6, 2024 · 0 comments

averissimo commented Feb 6, 2024

code-coverage.yml will always generate badges, even with workflow inputs skip-coverage-badges: true

I guess the || operator should change to && on the line below.

admiralci/.github/workflows/code-coverage.yml

Lines 186 to 188 in ad4c51f

    
               if: > 
        
                 inputs.skip-coverage-badges != 'true' || 
        
                   !contains(github.event.commits[0].message, '[skip coverage]')

This was detected as we don't have the badges branch on xportr 😅

Job in question: https://github.com/atorus-research/xportr/actions/runs/7803192342/job/21282556815

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment