Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to delete the Levenshtein distance implementation in Array because it's never used and produces an exception? #29

Open
bloomabir opened this issue Apr 19, 2022 · 2 comments

Comments

@bloomabir
Copy link

No description provided.

@bloomabir bloomabir changed the title We need to delete the Levenshtein distance implementation in Array because it's never used and produes n We need to delete the Levenshtein distance implementation in Array because it's never used and produces an exception. Apr 19, 2022
@jordanmontt jordanmontt changed the title We need to delete the Levenshtein distance implementation in Array because it's never used and produces an exception. Do we need to delete the Levenshtein distance implementation in Array because it's never used and produces an exception? Apr 19, 2022
@jordanmontt
Copy link
Member

Hello Hernan @hernanmd I hope that you are doing fine. We were working with Abir @bloomabir and we saw that there is two implementations of levenshteinDistanceTo: One is on Array and the other one is on String.

As far as we look at it, the Levenshtein distance only makes sense for characters, not for numbers. And also, we try to use the array implementation with: #(1 2 3) levenshteinDistanceTo: #(1 2 4) or also #(A B C) levenshteinDistanceTo: #(A B D) but both of them produce an exception.

So, do we delete the Array implementation? What do you think?

Thanks,
Sebastian

@hernanmd
Copy link
Member

hernanmd commented May 5, 2022

Hi @jordanmontt . I'm not fully clear, why Levenshtein distance could not be implemented in Array or even SequenceableCollection?

Why does it produces an exception?

I see nothing wrong having two implementations. The fact that an additional implementation in Array or SequenceableCollection is not working does not mean that should be deleted, but fixed.

@jordanmontt jordanmontt reopened this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants