Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove annoying node dots on branches #348

Open
arlin opened this issue Apr 4, 2019 · 10 comments
Open

remove annoying node dots on branches #348

arlin opened this issue Apr 4, 2019 · 10 comments
Assignees
Labels

Comments

@arlin
Copy link
Member

arlin commented Apr 4, 2019

Screen Shot 2019-04-04 at 3 10 01 PM
Trees are once again appearing with dots or squares for internal nodes with 1 child. Users do not expect this and do not know what it means. Therefore, it is confusing. Please remove it.

@bomeara
Copy link
Member

bomeara commented Apr 5, 2019

Generally, having an option to return a tree without singleton nodes would be great -- it would fix the problem here, as well as for some of @jwiggi18's current work intended for displaying trees on EOL

@abusalehmdtayeen
Copy link

I have added the singleton node removal feature by default as @bomeara suggested. I think it is fixed now. @arlin can you please test your example again?

@arlin
Copy link
Member Author

arlin commented Apr 6, 2019

Thanks!
Screen Shot 2019-04-06 at 9.17.33 AM.png

@arlin arlin closed this as completed Apr 6, 2019
@arlin arlin removed the in progress label Apr 6, 2019
@arlin arlin reopened this Apr 18, 2019
@arlin
Copy link
Member Author

arlin commented Apr 18, 2019

I'm seeing this problem again. I think that the problem was never fixed. I don't see a problem with the original tree, only with the scaled trees.

To reproduce the bug, here is what to do. Begin with this list

  • Equus caballus
  • Cervus canadensis
  • Sus scrofa
  • Balaenoptera acutorostrata
  • Balaena mysticetus
  • Orcinus orca
  • Platanista gangetica
  • Hippopotamus amphibius
  • Mirounga leonina
  • Hydrurga leptonyx
  • Phoca vitulina
  • Otaria byronia
  • Elephas maximus
  • Dugong dugon
  • Trichechus manatus
  • Ursus maritimus
  • Procyon lotor

Get the tree. Get the OT scaled tree. Add the 3 yellow boxes.

Now do the same thing, but use the Median scaled tree. the images below show both of them.
median_scaled.png
ot_scaled.png

@arlin arlin added ready and removed in progress labels Apr 18, 2019
@abusalehmdtayeen
Copy link

@ducvan0212, I think the problem is happening because ete preserves the node actions between different calls. Since the tree is changed after scaling, sometimes the boxes remain in their old places. Can you please change the treeid every time scaling method is called. That would reset the actions and probably solve the problem.

@ducvan0212
Copy link
Collaborator

@abusalehmdtayeen can you check if the issue still exists?

@abusalehmdtayeen
Copy link

abusalehmdtayeen commented Apr 22, 2019

I think the problem is fixed now. We clear the node actions when any scaling method is applied. So the user needs to reapply his actions for the new version of the tree.

@abusalehmdtayeen
Copy link

@arlin , if you are referring to the little misplaced dots, then we can't fix it. It is an internal issue of ETE.

@arlin
Copy link
Member Author

arlin commented May 1, 2019

is the fix on production yet? I tried it tonight and I still see the problem.

@abusalehmdtayeen
Copy link

@arlin , I think I have finally fixed the problem. Can you please check? I want to close this issue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants