You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now Pico Synth exists in a sort of purgatory- it includes an hpp and cpp file which can be included piecemeal into another project, but doesn't have a CMake file to make it easy to do this. As such using it results in stuff like:
In addition to this, identical functions for bringing up audio and running Pico Synth over i2s appear in the Cosmic, Galactic and Stellar Unicorn libraries.
Normally we'd need to fix this in short order, since repeating this code across 3 libraries is throwing away flash memory bytes we're already really short of, but we build separate Cosmic, Stellar and Galactic firmwares which just include their own drives and thus one copy of synth and the audio driver.
This issue is a gentle reminder to myself to "fix" this when I've got the time.
The text was updated successfully, but these errors were encountered:
Right now Pico Synth exists in a sort of purgatory- it includes an hpp and cpp file which can be included piecemeal into another project, but doesn't have a CMake file to make it easy to do this. As such using it results in stuff like:
pimoroni-pico/libraries/stellar_unicorn/stellar_unicorn.hpp
Line 6 in f18f1ba
and:
pimoroni-pico/libraries/stellar_unicorn/stellar_unicorn.cmake
Line 13 in f18f1ba
Which is functional, but ugly.
In addition to this, identical functions for bringing up audio and running Pico Synth over i2s appear in the Cosmic, Galactic and Stellar Unicorn libraries.
Normally we'd need to fix this in short order, since repeating this code across 3 libraries is throwing away flash memory bytes we're already really short of, but we build separate Cosmic, Stellar and Galactic firmwares which just include their own drives and thus one copy of synth and the audio driver.
This issue is a gentle reminder to myself to "fix" this when I've got the time.
The text was updated successfully, but these errors were encountered: