Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request pg17 support #51

Open
crunchyjohn opened this issue Sep 12, 2024 · 3 comments · May be fixed by #52
Open

Request pg17 support #51

crunchyjohn opened this issue Sep 12, 2024 · 3 comments · May be fixed by #52
Labels
D1: easy Difficulty: Easy to implement T: feature Type: Feature request U1: want to have Urgency: Want to have

Comments

@crunchyjohn
Copy link

Hello!

I would like to request pg17 support for pgx_ulid.

When I build against PG17 using the latest released version (v0.1.5), I get the following error:

error: unexpected argument '--pg17' found

  tip: a similar argument exists: '--pg16'

Usage: cargo pgrx init <--pg11 <PG11>|--pg12 <PG12>|--pg13 <PG13>|--pg14 <PG14>|--pg15 <PG15>|--pg16 <PG16>|--base-port <BASE_PORT>|--base-testing-port <BASE_TESTING_PORT>|--configure-flag <CONFIGURE_FLAG>|--valgrind>

For more information, try '--help'.

Taking a quick look, I can see that at a minimum, PG17 needs to be added to the top level Cargo.toml file:

I am unsure if more changes would be required.

Thanks!

@pksunkara
Copy link
Owner

The underlying pgrx needs to be updated

@pksunkara pksunkara added T: feature Type: Feature request Z: help wanted Z: Need help W: external Waiting: External D1: easy Difficulty: Easy to implement U1: want to have Urgency: Want to have and removed Z: help wanted Z: Need help labels Sep 12, 2024
@arjunyel
Copy link

pgrx just added PG17 support https://github.com/pgcentralfoundation/pgrx/releases/tag/v0.12.5

@pksunkara pksunkara removed the W: external Waiting: External label Sep 27, 2024
pksunkara added a commit that referenced this issue Sep 27, 2024
@pksunkara pksunkara linked a pull request Sep 27, 2024 that will close this issue
pksunkara added a commit that referenced this issue Sep 27, 2024
pksunkara added a commit that referenced this issue Sep 27, 2024
@pksunkara
Copy link
Owner

Looks like a few issues:

  1. postgresql-server-dev-17 seems to be missing for ubuntu arm.
  2. Updating pgrx seemed to break the code and therefore needs fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1: easy Difficulty: Easy to implement T: feature Type: Feature request U1: want to have Urgency: Want to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants