Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor method 'assets:create' does not respect 'noSelect' #44

Open
marklundin opened this issue May 5, 2022 · 0 comments
Open

editor method 'assets:create' does not respect 'noSelect' #44

marklundin opened this issue May 5, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@marklundin
Copy link
Member

I know this is the private editor api but thought it worth flagging as it's something we run into whilst developing a PC chrome extension;

In the Code Editor api, there is a method assets:create:script which subsequently calls assets:create with a third boolean parameter noSelect which if I'm correct, should create a script but then optionally select it in the tree view after it's created. The function for assets:create however ignores this parameter and continues to select it by default regardless of the noSelect

Steps to repro:
In the code editor console dropthe following:
editor.call('assets:create:script', { noSelect: true })

Note how the script is created and also selected ignoring the noSelect param

I believe that line 8645 in the compiled code editor script should only execute if args.noSelect is true

@willeastcott willeastcott added the bug Something isn't working label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants