-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dive CI Integration for checking WastedBytes #340
Comments
Hey @ImreSamu, I'm developing an open-source action that utilizes Dive for image analysis and size tracking in pull requests. I'd like to work on this issue to gain insight into the essential features I should include in my action. Could you please let me know your requirements so I can consider them while building it? Thanks! Currently, my implementation comments the analysis details on the PR using 📊 bitnami Image Analysis (Commit: [commit] )Summary
Inefficient Files:
|
Hi @PiyushRaj927, Thank you for your interest. At the moment, my ideas for the ideal solution are still somewhat vague, but I'd like to highlight three main points: 1.) Thus, it would be desirable to have a single consolidated analysis (comment) for the 17 images and, if possible, to arrange them into groups since we are working with three basic templates (Alpine, Debian, Master) and, therefore, the causes of some type errors are to be found here. see the current jobs matrix : https://github.com/postgis/docker-postgis/blob/master/.github/workflows/main.yml 2.) 3.) a.) Size increase attributable to external system updates and upstream image issues (In our case, this could be detected by finding file names causing the size increase that b.) If the size increase is due to non-compliance with Docker image best practices, which typically includes everything not covered in the previous (3a) point --> In this case, the check should stop and signal the problem with an appropriate message. It's important to note that these thoughts are my personal ideas, which may later be refined, modified, or changed. Moreover, these haven't been discussed yet with the other contributors at the repository level. |
See https://github.com/wagoodman/dive#ci-integration
Reason: #339 (comment) ( Alpine WastedBytes = 263 MB ! )
The text was updated successfully, but these errors were encountered: