diff --git a/adapters/brightroll/brightroll.go b/adapters/brightroll/brightroll.go deleted file mode 100644 index a917fe87277..00000000000 --- a/adapters/brightroll/brightroll.go +++ /dev/null @@ -1,263 +0,0 @@ -package brightroll - -import ( - "encoding/json" - "fmt" - "net/http" - "strconv" - - "github.com/prebid/openrtb/v19/adcom1" - "github.com/prebid/openrtb/v19/openrtb2" - "github.com/prebid/prebid-server/adapters" - "github.com/prebid/prebid-server/config" - "github.com/prebid/prebid-server/errortypes" - "github.com/prebid/prebid-server/openrtb_ext" -) - -type BrightrollAdapter struct { - URI string - extraInfo ExtraInfo -} - -type ExtraInfo struct { - Accounts []Account `json:"accounts"` -} - -type Account struct { - ID string `json:"id"` - Badv []string `json:"badv"` - Bcat []string `json:"bcat"` - Battr []int8 `json:"battr"` - BidFloor float64 `json:"bidfloor"` -} - -func (a *BrightrollAdapter) MakeRequests(requestIn *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) { - - request := *requestIn - errs := make([]error, 0, len(request.Imp)) - if len(request.Imp) == 0 { - err := &errortypes.BadInput{ - Message: "No impression in the bid request", - } - errs = append(errs, err) - return nil, errs - } - - errors := make([]error, 0, 1) - - var bidderExt adapters.ExtImpBidder - err := json.Unmarshal(request.Imp[0].Ext, &bidderExt) - if err != nil { - err = &errortypes.BadInput{ - Message: "ext.bidder not provided", - } - errors = append(errors, err) - return nil, errors - } - var brightrollExt openrtb_ext.ExtImpBrightroll - err = json.Unmarshal(bidderExt.Bidder, &brightrollExt) - if err != nil { - err = &errortypes.BadInput{ - Message: "ext.bidder.publisher not provided", - } - errors = append(errors, err) - return nil, errors - } - if brightrollExt.Publisher == "" { - err = &errortypes.BadInput{ - Message: "publisher is empty", - } - errors = append(errors, err) - return nil, errors - } - - var account *Account - for _, a := range a.extraInfo.Accounts { - if a.ID == brightrollExt.Publisher { - account = &a - break - } - } - - if account == nil { - err = &errortypes.BadInput{ - Message: "Invalid publisher", - } - errors = append(errors, err) - return nil, errors - } - - validImpExists := false - for i := 0; i < len(request.Imp); i++ { - //Brightroll supports only banner and video impressions as of now - if request.Imp[i].Banner != nil { - bannerCopy := *request.Imp[i].Banner - if bannerCopy.W == nil && bannerCopy.H == nil && len(bannerCopy.Format) > 0 { - firstFormat := bannerCopy.Format[0] - bannerCopy.W = &(firstFormat.W) - bannerCopy.H = &(firstFormat.H) - } - - if len(account.Battr) > 0 { - bannerCopy.BAttr = getBlockedCreativetypes(account.Battr) - } - request.Imp[i].Banner = &bannerCopy - validImpExists = true - } else if request.Imp[i].Video != nil { - validImpExists = true - if brightrollExt.Publisher == "adthrive" { - videoCopy := *request.Imp[i].Video - if len(account.Battr) > 0 { - videoCopy.BAttr = getBlockedCreativetypes(account.Battr) - } - request.Imp[i].Video = &videoCopy - } - } - if validImpExists && request.Imp[i].BidFloor == 0 && account.BidFloor > 0 { - request.Imp[i].BidFloor = account.BidFloor - } - } - if !validImpExists { - err := &errortypes.BadInput{ - Message: fmt.Sprintf("No valid impression in the bid request"), - } - errs = append(errs, err) - return nil, errs - } - - request.AT = 1 //Defaulting to first price auction for all prebid requests - - if len(account.Bcat) > 0 { - request.BCat = account.Bcat - } - - if len(account.Badv) > 0 { - request.BAdv = account.Badv - } - reqJSON, err := json.Marshal(request) - if err != nil { - errs = append(errs, err) - return nil, errs - } - thisURI := a.URI - thisURI = thisURI + "?publisher=" + brightrollExt.Publisher - headers := http.Header{} - headers.Add("Content-Type", "application/json;charset=utf-8") - headers.Add("Accept", "application/json") - headers.Add("x-openrtb-version", "2.5") - - if request.Device != nil { - addHeaderIfNonEmpty(headers, "User-Agent", request.Device.UA) - addHeaderIfNonEmpty(headers, "X-Forwarded-For", request.Device.IP) - addHeaderIfNonEmpty(headers, "Accept-Language", request.Device.Language) - if request.Device.DNT != nil { - addHeaderIfNonEmpty(headers, "DNT", strconv.Itoa(int(*request.Device.DNT))) - } - } - - return []*adapters.RequestData{{ - Method: "POST", - Uri: thisURI, - Body: reqJSON, - Headers: headers, - }}, errors -} - -func (a *BrightrollAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) { - - if response.StatusCode == http.StatusNoContent { - return nil, nil - } - - if response.StatusCode == http.StatusBadRequest { - return nil, []error{&errortypes.BadInput{ - Message: fmt.Sprintf("Unexpected status code: %d. ", response.StatusCode), - }} - } - - if response.StatusCode != http.StatusOK { - return nil, []error{&errortypes.BadServerResponse{ - Message: fmt.Sprintf("unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode), - }} - } - - var bidResp openrtb2.BidResponse - if err := json.Unmarshal(response.Body, &bidResp); err != nil { - return nil, []error{&errortypes.BadServerResponse{ - Message: fmt.Sprintf("bad server response: %d. ", err), - }} - } - - bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(bidResp.SeatBid[0].Bid)) - sb := bidResp.SeatBid[0] - for i := 0; i < len(sb.Bid); i++ { - bid := sb.Bid[i] - bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{ - Bid: &bid, - BidType: getMediaTypeForImp(bid.ImpID, internalRequest.Imp), - }) - } - return bidResponse, nil -} - -func getBlockedCreativetypes(attr []int8) []adcom1.CreativeAttribute { - var creativeAttr []adcom1.CreativeAttribute - for i := 0; i < len(attr); i++ { - creativeAttr = append(creativeAttr, adcom1.CreativeAttribute(attr[i])) - } - return creativeAttr -} - -// Adding header fields to request header -func addHeaderIfNonEmpty(headers http.Header, headerName string, headerValue string) { - if len(headerValue) > 0 { - headers.Add(headerName, headerValue) - } -} - -// getMediaTypeForImp figures out which media type this bid is for. -func getMediaTypeForImp(impId string, imps []openrtb2.Imp) openrtb_ext.BidType { - mediaType := openrtb_ext.BidTypeBanner //default type - for _, imp := range imps { - if imp.ID == impId { - if imp.Video != nil { - mediaType = openrtb_ext.BidTypeVideo - } - return mediaType - } - } - return mediaType -} - -// Builder builds a new instance of the Brightroll adapter for the given bidder with the given config. -func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { - extraInfo, err := getExtraInfo(config.ExtraAdapterInfo) - if err != nil { - return nil, err - } - - bidder := &BrightrollAdapter{ - URI: config.Endpoint, - extraInfo: extraInfo, - } - return bidder, nil -} - -func getExtraInfo(v string) (ExtraInfo, error) { - if len(v) == 0 { - return getDefaultExtraInfo(), nil - } - - var extraInfo ExtraInfo - if err := json.Unmarshal([]byte(v), &extraInfo); err != nil { - return extraInfo, fmt.Errorf("invalid extra info: %v", err) - } - - return extraInfo, nil -} - -func getDefaultExtraInfo() ExtraInfo { - return ExtraInfo{ - Accounts: []Account{}, - } -} diff --git a/adapters/brightroll/brightroll_test.go b/adapters/brightroll/brightroll_test.go deleted file mode 100644 index 4cf0f46fda7..00000000000 --- a/adapters/brightroll/brightroll_test.go +++ /dev/null @@ -1,73 +0,0 @@ -package brightroll - -import ( - "testing" - - "github.com/stretchr/testify/assert" - - "github.com/prebid/prebid-server/adapters/adapterstest" - "github.com/prebid/prebid-server/config" - "github.com/prebid/prebid-server/openrtb_ext" -) - -func TestEmptyConfig(t *testing.T) { - bidder, buildErr := Builder(openrtb_ext.BidderBrightroll, config.Adapter{ - Endpoint: `http://test-bid.ybp.yahoo.com/bid/appnexuspbs`, - ExtraAdapterInfo: ``, - }, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) - - if buildErr != nil { - t.Fatalf("Builder returned unexpected error %v", buildErr) - } - - ex := ExtraInfo{ - Accounts: []Account{}, - } - expected := &BrightrollAdapter{ - URI: "http://test-bid.ybp.yahoo.com/bid/appnexuspbs", - extraInfo: ex, - } - assert.Equal(t, expected, bidder) -} - -func TestNonEmptyConfig(t *testing.T) { - bidder, buildErr := Builder(openrtb_ext.BidderBrightroll, config.Adapter{ - Endpoint: `http://test-bid.ybp.yahoo.com/bid/appnexuspbs`, - ExtraAdapterInfo: `{"accounts": [{"id": "test","bidfloor":0.1}]}`, - }, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) - - if buildErr != nil { - t.Fatalf("Builder returned unexpected error %v", buildErr) - } - - ex := ExtraInfo{ - Accounts: []Account{{ID: "test", BidFloor: 0.1}}, - } - expected := &BrightrollAdapter{ - URI: "http://test-bid.ybp.yahoo.com/bid/appnexuspbs", - extraInfo: ex, - } - assert.Equal(t, expected, bidder) -} - -func TestMalformedEmpty(t *testing.T) { - _, buildErr := Builder(openrtb_ext.BidderBrightroll, config.Adapter{ - Endpoint: `http://test-bid.ybp.yahoo.com/bid/appnexuspbs`, - ExtraAdapterInfo: `malformed`, - }, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) - - assert.Error(t, buildErr) -} - -func TestJsonSamples(t *testing.T) { - bidder, buildErr := Builder(openrtb_ext.BidderBrightroll, config.Adapter{ - Endpoint: `http://test-bid.ybp.yahoo.com/bid/appnexuspbs`, - ExtraAdapterInfo: `{"accounts": [{"id": "adthrive","badv": [], "bcat": ["IAB8-5","IAB8-18"],"battr": [1,2,3], "bidfloor":0.0}]}`, - }, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) - - if buildErr != nil { - t.Fatalf("Builder returned unexpected error %v", buildErr) - } - - adapterstest.RunJSONBidderTest(t, "brightrolltest", bidder) -} diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json b/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json deleted file mode 100644 index f67fa259c6d..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json +++ /dev/null @@ -1,169 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-native-imp", - "native": { - "ver": "1.1", - "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-audio-imp", - "audio": { - "mimes": [ - "video/mp4" - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - }, - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "banner": { - "battr": [ - 1, - 2, - 3 - ], - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ], - "w": 300, - "h": 250 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-native-imp", - "native": { - "ver": "1.1", - "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-audio-imp", - "audio": { - "mimes": [ - "video/mp4" - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "seat": "958", - "bid": [{ - "id": "7706636740145184841", - "impid": "test-imp-id", - "price": 0.500000, - "adid": "29681110", - "adm": "some-test-ad", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "h": 250, - "w": 300 - }] - } - ], - "bidid": "5778926625248726496", - "cur": "USD" - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [ - { - "bid": { - "id": "7706636740145184841", - "impid": "test-imp-id", - "price": 0.5, - "adm": "some-test-ad", - "adid": "29681110", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] - -} diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json b/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json deleted file mode 100644 index 97081b708d3..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json +++ /dev/null @@ -1,176 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-native-imp", - "native": { - "ver": "1.1", - "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "test-imp-video-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - }, - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "banner": { - "battr": [ - 1, - 2, - 3 - ], - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ], - "w": 300, - "h": 250 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-native-imp", - "native": { - "ver": "1.1", - "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "test-imp-video-id", - "video": { - "battr": [ - 1, - 2, - 3 - ], - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "seat": "958", - "bid": [{ - "id": "7706636740145184841", - "impid": "test-imp-video-id", - "price": 0.500000, - "adid": "29681110", - "adm": "some-test-ad", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "h": 576, - "w": 1024 - }] - } - ], - "bidid": "5778926625248726496", - "cur": "USD" - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [ - { - "bid": { - "id": "7706636740145184841", - "impid": "test-imp-video-id", - "price": 0.5, - "adm": "some-test-ad", - "adid": "29681110", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "w": 1024, - "h": 576 - }, - "type": "video" - } - ] - } - ] - -} diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-video.json b/adapters/brightroll/brightrolltest/exemplary/banner-video.json deleted file mode 100644 index 17441152edc..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/banner-video.json +++ /dev/null @@ -1,152 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "test-imp-video-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - }, - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "banner": { - "battr": [ - 1, - 2, - 3 - ], - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ], - "w": 300, - "h": 250 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "test-imp-video-id", - "video": { - "battr": [ - 1, - 2, - 3 - ], - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "seat": "958", - "bid": [{ - "id": "7706636740145184841", - "impid": "test-imp-video-id", - "price": 0.500000, - "adid": "29681110", - "adm": "some-test-ad", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "h": 576, - "w": 1024 - }] - } - ], - "bidid": "5778926625248726496", - "cur": "USD" - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [ - { - "bid": { - "id": "7706636740145184841", - "impid": "test-imp-video-id", - "price": 0.5, - "adm": "some-test-ad", - "adid": "29681110", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "w": 1024, - "h": 576 - }, - "type": "video" - } - ] - } - ] - -} diff --git a/adapters/brightroll/brightrolltest/exemplary/simple-banner.json b/adapters/brightroll/brightrolltest/exemplary/simple-banner.json deleted file mode 100644 index f59038503cf..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/simple-banner.json +++ /dev/null @@ -1,119 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - }, - - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "banner": { - "battr": [ - 1, - 2, - 3 - ], - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ], - "w": 300, - "h": 250 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "seatbid": [ - { - "seat": "958", - "bid": [{ - "id": "7706636740145184841", - "impid": "test-imp-id", - "price": 0.500000, - "adid": "29681110", - "adm": "some-test-ad", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "h": 250, - "w": 300 - }] - } - ], - "bidid": "5778926625248726496", - "cur": "USD" - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [ - { - "bid": { - "id": "7706636740145184841", - "impid": "test-imp-id", - "price": 0.5, - "adm": "some-test-ad", - "adid": "29681110", - "adomain": ["yahoo.com"], - "cid": "958", - "crid": "29681110", - "w": 300, - "h": 250 - }, - "type": "banner" - } - ] - } - ] -} diff --git a/adapters/brightroll/brightrolltest/exemplary/simple-video.json b/adapters/brightroll/brightrolltest/exemplary/simple-video.json deleted file mode 100644 index 88539276043..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/simple-video.json +++ /dev/null @@ -1,98 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext":{ - "bidder":{ - "publisher": "adthrive" - } - } - } - ] - }, - - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "video": { - "battr": [ - 1, - 2, - 3 - ], - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "cur": "USD", - "seatbid": [ - { - "seat": "Brightroll", - "bid": [{ - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-id", - "price": 0.500000, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [ - { - "bid": { - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-id", - "price": 0.5, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }, - "type": "video" - } - ] - } - ] -} diff --git a/adapters/brightroll/brightrolltest/exemplary/valid-extension.json b/adapters/brightroll/brightrolltest/exemplary/valid-extension.json deleted file mode 100644 index 9a5e571ce1b..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/valid-extension.json +++ /dev/null @@ -1,96 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext":{ - "bidder":{ - "publisher": "adthrive" - } - } - } - ] - }, - - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-id", - "video": { - "battr": [ - 1, - 2, - 3 - ], - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "cur": "USD", - "seatbid": [ - { - "seat": "brightroll", - "bid": [{ - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-id", - "price": 0.500000, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [{ - "bid": { - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-id", - "price": 0.5, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }, - "type": "video" - }] - } - ] -} diff --git a/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json b/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json deleted file mode 100644 index 4184842b60e..00000000000 --- a/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json +++ /dev/null @@ -1,121 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-imp-video-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-audio-imp", - "audio": { - "mimes": [ - "video/mp4" - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - }, - "httpCalls": [ - { - "expectedRequest": { - "uri": "http://test-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=adthrive", - "body": { - "id": "test-request-id", - "at":1, - "bcat": [ - "IAB8-5", - "IAB8-18" - ], - "imp": [ - { - "id": "test-imp-video-id", - "video": { - "battr": [ - 1, - 2, - 3 - ], - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - { - "id": "unsupported-audio-imp", - "audio": { - "mimes": [ - "video/mp4" - ] - }, - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - } - ] - } - }, - "mockResponse": { - "status": 200, - "body": { - "id": "test-request-id", - "cur": "USD", - "seatbid": [ - { - "seat": "brightroll", - "bid": [{ - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-video-id", - "price": 0.500000, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }] - } - ] - } - } - } - ], - - "expectedBidResponses": [ - { - "bids": [{ - "bid": { - "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", - "impid": "test-imp-video-id", - "price": 0.5, - "adm": "some-test-ad", - "crid": "crid_10", - "w": 1024, - "h": 576 - }, - "type": "video" - }] - } - ] -} diff --git a/adapters/brightroll/brightrolltest/supplemental/invalid-extension.json b/adapters/brightroll/brightrolltest/supplemental/invalid-extension.json deleted file mode 100644 index 35b1563822f..00000000000 --- a/adapters/brightroll/brightrolltest/supplemental/invalid-extension.json +++ /dev/null @@ -1,31 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-invalid-ext-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - } - - } - ] - }, - "expectedMakeRequestsErrors": [ - { - "value": "ext.bidder.publisher not provided", - "comparison": "literal" - } - ] -} diff --git a/adapters/brightroll/brightrolltest/supplemental/invalid-imp.json b/adapters/brightroll/brightrolltest/supplemental/invalid-imp.json deleted file mode 100644 index 01beec712c7..00000000000 --- a/adapters/brightroll/brightrolltest/supplemental/invalid-imp.json +++ /dev/null @@ -1,16 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "ext": { - "bidder": { - "publisher": "adthrive" - } - } - }, - "expectedMakeRequestsErrors": [ - { - "value": "No impression in the bid request", - "comparison": "literal" - } - ] -} diff --git a/adapters/brightroll/brightrolltest/supplemental/invalid-publisher.json b/adapters/brightroll/brightrolltest/supplemental/invalid-publisher.json deleted file mode 100644 index da48108af0b..00000000000 --- a/adapters/brightroll/brightrolltest/supplemental/invalid-publisher.json +++ /dev/null @@ -1,34 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-missing-req-param-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher":"test" - } - } - - } - ] - }, - "expectedMakeRequestsErrors": [ - { - "value": "Invalid publisher", - "comparison": "literal" - } - ] -} \ No newline at end of file diff --git a/adapters/brightroll/brightrolltest/supplemental/missing-extension.json b/adapters/brightroll/brightrolltest/supplemental/missing-extension.json deleted file mode 100644 index 82ec775da30..00000000000 --- a/adapters/brightroll/brightrolltest/supplemental/missing-extension.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-missing-ext-id", - "video": { - "mimes": ["video/mp4"], - "protocols": [2, 5], - "w": 1024, - "h": 576 - } - } - ] - }, - "expectedMakeRequestsErrors": [ - { - "value": "ext.bidder not provided", - "comparison": "literal" - } - ] -} \ No newline at end of file diff --git a/adapters/brightroll/brightrolltest/supplemental/missing-param.json b/adapters/brightroll/brightrolltest/supplemental/missing-param.json deleted file mode 100644 index 08e82c0e31c..00000000000 --- a/adapters/brightroll/brightrolltest/supplemental/missing-param.json +++ /dev/null @@ -1,34 +0,0 @@ -{ - "mockBidRequest": { - "id": "test-request-id", - "imp": [ - { - "id": "test-missing-req-param-id", - "banner": { - "format": [ - { - "w": 300, - "h": 250 - }, - { - "w": 300, - "h": 600 - } - ] - }, - "ext": { - "bidder": { - "publisher":"" - } - } - - } - ] - }, - "expectedMakeRequestsErrors": [ - { - "value": "publisher is empty", - "comparison": "literal" - } - ] -} diff --git a/adapters/brightroll/params_test.go b/adapters/brightroll/params_test.go deleted file mode 100644 index c14ee6d73ff..00000000000 --- a/adapters/brightroll/params_test.go +++ /dev/null @@ -1,62 +0,0 @@ -package brightroll - -import ( - "encoding/json" - "testing" - - "github.com/prebid/prebid-server/openrtb_ext" -) - -// This file actually intends to test static/bidder-params/brightroll.json -// -// These also validate the format of the external API: request.imp[i].ext.prebid.bidder.brightroll - -// TestValidParams makes sure that the Brightroll schema accepts all imp.ext fields which we intend to support. -func TestValidParams(t *testing.T) { - validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params") - if err != nil { - t.Fatalf("Failed to fetch the json-schemas. %v", err) - } - - for _, validParam := range validParams { - if err := validator.Validate(openrtb_ext.BidderBrightroll, json.RawMessage(validParam)); err != nil { - t.Errorf("Schema rejected Brightroll params: %s", validParam) - } - } -} - -// TestInvalidParams makes sure that the Brightroll schema rejects all the imp.ext fields we don't support. -func TestInvalidParams(t *testing.T) { - validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params") - if err != nil { - t.Fatalf("Failed to fetch the json-schemas. %v", err) - } - - for _, invalidParam := range invalidParams { - if err := validator.Validate(openrtb_ext.BidderBrightroll, json.RawMessage(invalidParam)); err == nil { - t.Errorf("Schema allowed unexpected params: %s", invalidParam) - } - } -} - -var validParams = []string{ - `{"publisher": "testpublisher"}`, - `{"publisher": "123"}`, - `{"publisher": "cafemedia"}`, - `{"publisher": "test", "headerbidding": false}`, -} - -var invalidParams = []string{ - `{"publisher": 100}`, - `{"headerbidding": false}`, - `{"publisher": true}`, - `{"publisherId": 123, "headerbidding": true}`, - `{"publisherID": "1"}`, - ``, - `null`, - `true`, - `9`, - `1.2`, - `[]`, - `{}`, -} diff --git a/adapters/gamma/params_test.go b/adapters/gamma/params_test.go index 56f1b591190..c6a149c23bc 100644 --- a/adapters/gamma/params_test.go +++ b/adapters/gamma/params_test.go @@ -8,8 +8,6 @@ import ( ) // This file actually intends to test static/bidder-params/gamma.json -// -// These also validate the format of the external API: request.imp[i].ext.prebid.bidder.brightroll // TestValidParams makes sure that the Gamma schema accepts all imp.ext fields which we intend to support. func TestValidParams(t *testing.T) { diff --git a/config/config_test.go b/config/config_test.go index 402f9ada8db..30733372135 100644 --- a/config/config_test.go +++ b/config/config_test.go @@ -885,7 +885,6 @@ func TestUserSyncFromEnv(t *testing.T) { assert.Nil(t, cfg.BidderInfos["bidder2"].Syncer.Redirect) assert.Nil(t, cfg.BidderInfos["bidder2"].Syncer.SupportCORS) - assert.Nil(t, cfg.BidderInfos["brightroll"].Syncer) } func TestBidderInfoFromEnv(t *testing.T) { diff --git a/endpoints/openrtb2/auction_test.go b/endpoints/openrtb2/auction_test.go index 4be48811d00..b39f6e03c00 100644 --- a/endpoints/openrtb2/auction_test.go +++ b/endpoints/openrtb2/auction_test.go @@ -1627,7 +1627,7 @@ func TestValidateRequest(t *testing.T) { Ext: []byte(`{"appnexus":{"placementId": 12345678}}`), }, }, - Ext: []byte(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids":{"pubmatic1":1}}}`), + Ext: []byte(`{"prebid":{"aliases":{"yahoossp":"appnexus"}, "aliasgvlids":{"pubmatic1":1}}}`), }, }, givenIsAmp: false, @@ -1658,11 +1658,11 @@ func TestValidateRequest(t *testing.T) { Ext: []byte(`{"appnexus":{"placementId": 12345678}}`), }, }, - Ext: []byte(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids":{"brightroll":0}}}`), + Ext: []byte(`{"prebid":{"aliases":{"yahoossp":"appnexus"}, "aliasgvlids":{"yahoossp":0}}}`), }, }, givenIsAmp: false, - expectedErrorList: []error{errors.New("request.ext.prebid.aliasgvlids. Invalid vendorId 0 for alias: brightroll. Choose a different vendorId, or remove this entry.")}, + expectedErrorList: []error{errors.New("request.ext.prebid.aliasgvlids. Invalid vendorId 0 for alias: yahoossp. Choose a different vendorId, or remove this entry.")}, expectedChannelObject: &openrtb_ext.ExtRequestPrebidChannel{Name: appChannel, Version: ""}, }, { @@ -1689,7 +1689,7 @@ func TestValidateRequest(t *testing.T) { Ext: []byte(`{"appnexus":{"placementId": 12345678}}`), }, }, - Ext: []byte(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids":{"brightroll":1}}}`), + Ext: []byte(`{"prebid":{"aliases":{"yahoossp":"appnexus"}, "aliasgvlids":{"yahoossp":1}}}`), }, }, givenIsAmp: false, diff --git a/exchange/adapter_builders.go b/exchange/adapter_builders.go index 6d0a4d8019a..96d6aa64b0f 100755 --- a/exchange/adapter_builders.go +++ b/exchange/adapter_builders.go @@ -56,7 +56,6 @@ import ( "github.com/prebid/prebid-server/adapters/bmtm" "github.com/prebid/prebid-server/adapters/boldwin" "github.com/prebid/prebid-server/adapters/brave" - "github.com/prebid/prebid-server/adapters/brightroll" "github.com/prebid/prebid-server/adapters/ccx" "github.com/prebid/prebid-server/adapters/coinzilla" "github.com/prebid/prebid-server/adapters/colossus" @@ -243,7 +242,6 @@ func newAdapterBuilders() map[openrtb_ext.BidderName]adapters.Builder { openrtb_ext.BidderBmtm: bmtm.Builder, openrtb_ext.BidderBoldwin: boldwin.Builder, openrtb_ext.BidderBrave: brave.Builder, - openrtb_ext.BidderBrightroll: brightroll.Builder, openrtb_ext.BidderCcx: ccx.Builder, openrtb_ext.BidderCoinzilla: coinzilla.Builder, openrtb_ext.BidderColossus: colossus.Builder, diff --git a/exchange/adapter_util.go b/exchange/adapter_util.go index 9551ab3ea69..624a22ce363 100644 --- a/exchange/adapter_util.go +++ b/exchange/adapter_util.go @@ -97,6 +97,7 @@ func GetDisabledBiddersErrorMessages(infos config.BidderInfos) map[string]string "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, "verizonmedia": `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, + "brightroll": `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, } for name, info := range infos { diff --git a/exchange/adapter_util_test.go b/exchange/adapter_util_test.go index 3b818bdd429..2f3c8e9abab 100644 --- a/exchange/adapter_util_test.go +++ b/exchange/adapter_util_test.go @@ -222,6 +222,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, "verizonmedia": `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, + "brightroll": `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, }, }, { @@ -236,6 +237,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, "verizonmedia": `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, + "brightroll": `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, }, }, { @@ -251,6 +253,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, "verizonmedia": `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, + "brightroll": `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, }, }, { @@ -266,6 +269,7 @@ func TestGetDisabledBiddersErrorMessages(t *testing.T) { "oftmedia": `Bidder "oftmedia" is no longer available in Prebid Server. Please update your configuration.`, "groupm": `Bidder "groupm" is no longer available in Prebid Server. Please update your configuration.`, "verizonmedia": `Bidder "verizonmedia" is no longer available in Prebid Server. Please update your configuration.`, + "brightroll": `Bidder "brightroll" is no longer available in Prebid Server. Please update your configuration.`, }, }, } diff --git a/exchange/utils_test.go b/exchange/utils_test.go index 973edc53355..b62e9597e0b 100644 --- a/exchange/utils_test.go +++ b/exchange/utils_test.go @@ -74,8 +74,6 @@ func assertReq(t *testing.T, bidderRequests []BidderRequest, assert.NotEqual(t, bidderRequests, 0, "cleanOpenRTBRequest should split request into individual bidder requests") // assert for PI data - // Both appnexus and brightroll should be allowed since brightroll - // is used as an alias for appnexus in the test request for _, req := range bidderRequests { if !applyCOPPA && consentedVendors[req.BidderName.String()] { assert.NotEqual(t, req.BidRequest.User.BuyerUID, "", "cleanOpenRTBRequest shouldn't clean PI data as per COPPA or for a consented vendor as per GDPR or per CCPA") @@ -459,7 +457,7 @@ func TestCleanOpenRTBRequests(t *testing.T) { bidReqAssertions: assertReq, hasError: false, applyCOPPA: false, - consentedVendors: map[string]bool{"appnexus": true, "brightroll": true}, + consentedVendors: map[string]bool{"appnexus": true}, }, } @@ -508,13 +506,6 @@ func TestCleanOpenRTBRequestsWithFPD(t *testing.T) { } fpd[openrtb_ext.BidderName("rubicon")] = &apnFpd - brightrollFpd := firstpartydata.ResolvedFirstPartyData{ - Site: &openrtb2.Site{Name: "fpdBrightrollSite"}, - App: &openrtb2.App{Name: "fpdBrightrollApp"}, - User: &openrtb2.User{Keywords: "fpdBrightrollUser"}, - } - fpd[openrtb_ext.BidderName("brightroll")] = &brightrollFpd - emptyTCF2Config := gdpr.NewTCF2Config(config.TCF2{}, config.AccountGDPR{}) testCases := []struct { @@ -2580,9 +2571,9 @@ func newAdapterAliasBidRequest(t *testing.T) *openrtb2.BidRequest { H: 600, }}, }, - Ext: json.RawMessage(`{"appnexus": {"placementId": 1},"brightroll": {"placementId": 105}}`), + Ext: json.RawMessage(`{"appnexus": {"placementId": 1},"somealias": {"placementId": 105}}`), }}, - Ext: json.RawMessage(`{"prebid":{"aliases":{"brightroll":"appnexus"}}}`), + Ext: json.RawMessage(`{"prebid":{"aliases":{"somealias":"appnexus"}}}`), } } @@ -3196,17 +3187,17 @@ func Test_parseAliasesGVLIDs(t *testing.T) { "AliasGVLID Parsed Correctly", args{ orig: &openrtb2.BidRequest{ - Ext: json.RawMessage(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids":{"brightroll":1}}}`), + Ext: json.RawMessage(`{"prebid":{"aliases":{"somealiascode":"appnexus"}, "aliasgvlids":{"somealiascode":1}}}`), }, }, - map[string]uint16{"brightroll": 1}, + map[string]uint16{"somealiascode": 1}, false, }, { "AliasGVLID parsing error", args{ orig: &openrtb2.BidRequest{ - Ext: json.RawMessage(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids": {"brightroll":"abc"}`), + Ext: json.RawMessage(`{"prebid":{"aliases":{"somealiascode":"appnexus"}, "aliasgvlids": {"somealiascode":"abc"}`), }, }, nil, @@ -3216,7 +3207,7 @@ func Test_parseAliasesGVLIDs(t *testing.T) { "Invalid AliasGVLID", args{ orig: &openrtb2.BidRequest{ - Ext: json.RawMessage(`{"prebid":{"aliases":{"brightroll":"appnexus"}, "aliasgvlids":"abc"}`), + Ext: json.RawMessage(`{"prebid":{"aliases":{"somealiascode":"appnexus"}, "aliasgvlids":"abc"}`), }, }, nil, @@ -3226,7 +3217,7 @@ func Test_parseAliasesGVLIDs(t *testing.T) { "Missing AliasGVLID", args{ orig: &openrtb2.BidRequest{ - Ext: json.RawMessage(`{"prebid":{"aliases":{"brightroll":"appnexus"}}`), + Ext: json.RawMessage(`{"prebid":{"aliases":{"somealiascode":"appnexus"}}`), }, }, nil, diff --git a/openrtb_ext/bidders.go b/openrtb_ext/bidders.go index a43861ddc49..2398af8e62a 100644 --- a/openrtb_ext/bidders.go +++ b/openrtb_ext/bidders.go @@ -142,7 +142,6 @@ const ( BidderBmtm BidderName = "bmtm" BidderBoldwin BidderName = "boldwin" BidderBrave BidderName = "brave" - BidderBrightroll BidderName = "brightroll" BidderCcx BidderName = "ccx" BidderCoinzilla BidderName = "coinzilla" BidderColossus BidderName = "colossus" @@ -342,7 +341,6 @@ func CoreBidderNames() []BidderName { BidderBmtm, BidderBoldwin, BidderBrave, - BidderBrightroll, BidderCcx, BidderCoinzilla, BidderColossus, diff --git a/openrtb_ext/imp_brightroll.go b/openrtb_ext/imp_brightroll.go deleted file mode 100644 index bd42d4aae5d..00000000000 --- a/openrtb_ext/imp_brightroll.go +++ /dev/null @@ -1,6 +0,0 @@ -package openrtb_ext - -// ExtImpBrightroll defines the contract for bidrequest.imp[i].ext.prebid.bidder.brightroll -type ExtImpBrightroll struct { - Publisher string `json:"publisher"` -} diff --git a/static/bidder-info/brightroll.yaml b/static/bidder-info/brightroll.yaml deleted file mode 100644 index 196344e9f25..00000000000 --- a/static/bidder-info/brightroll.yaml +++ /dev/null @@ -1,17 +0,0 @@ -endpoint: "http://east-bid.ybp.yahoo.com/bid/appnexuspbs" -maintainer: - email: "dsp-supply-prebid@verizonmedia.com" -gvlVendorID: 25 -capabilities: - app: - mediaTypes: - - banner - - video - site: - mediaTypes: - - banner - - video -userSync: - redirect: - url: "https://pr-bh.ybp.yahoo.com/sync/appnexusprebidserver/?gdpr={{.GDPR}}&euconsent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&url={{.RedirectURL}}" - userMacro: "$UID" diff --git a/static/bidder-params/brightroll.json b/static/bidder-params/brightroll.json deleted file mode 100644 index 48e48d8a36d..00000000000 --- a/static/bidder-params/brightroll.json +++ /dev/null @@ -1,13 +0,0 @@ -{ - "$schema": "http://json-schema.org/draft-04/schema#", - "title": "Brightroll Adapter Params", - "description": "A schema which validates params accepted by the Brightroll adapter", - "type": "object", - "properties": { - "publisher": { - "type": "string", - "description": "Publisher Name to use." - } - }, - "required": ["publisher"] -}