From 636a6e65a1a5212066e9b03297805df0a6b441d0 Mon Sep 17 00:00:00 2001
From: Felipe Dalcin <felipe@pressbooks.com>
Date: Thu, 18 Jul 2024 17:42:09 -0400
Subject: [PATCH] fix: reduce memory consumption while loading users

---
 resources/views/institutions/form.blade.php | 2 +-
 src/Controllers/InstitutionsController.php  | 6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/resources/views/institutions/form.blade.php b/resources/views/institutions/form.blade.php
index 9ff1fc77..4bfa9317 100644
--- a/resources/views/institutions/form.blade.php
+++ b/resources/views/institutions/form.blade.php
@@ -206,7 +206,7 @@ class="regular-text"
 								@else
 									<option
 										value="{{ $user->ID }}"
-										@if($institution->managers->contains(fn (object $institutionUser) => $institutionUser->user_id === $user->ID)))
+										@if($institution->managers->contains(fn (object $institutionUser) => $institutionUser->user_id === (int) $user->ID)))
 										selected
 										@endif
 									>
diff --git a/src/Controllers/InstitutionsController.php b/src/Controllers/InstitutionsController.php
index 83a1f972..c8926184 100644
--- a/src/Controllers/InstitutionsController.php
+++ b/src/Controllers/InstitutionsController.php
@@ -13,8 +13,6 @@
 use PressbooksMultiInstitution\Views\InstitutionsTable;
 use PressbooksMultiInstitution\Views\InstitutionsTotals;
 use PressbooksMultiInstitution\Support\ConvertEmptyStringsToNull;
-use stdClass;
-use WP_User;
 
 use function Pressbooks\Admin\NetworkManagers\is_restricted;
 
@@ -272,7 +270,7 @@ protected function fetchUsers(?Institution $institution): array
             ->pluck('ID')
             ->toArray();
 
-        $users = get_users([
+        return get_users([
             'blog_id' => 0, // all users from the network
             'fields' => ['ID', 'display_name', 'user_email'],
             'orderby' => [
@@ -282,8 +280,6 @@ protected function fetchUsers(?Institution $institution): array
             ],
             'exclude' => $usersToSkip
         ]);
-
-        return array_map(fn (stdClass $value) => new WP_User($value), $users);
     }
 
     protected function checkForInvalidDomains(array $domains): array