Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter for turning error logs off #139

Open
francescopellegrini opened this issue May 15, 2024 · 4 comments
Open

Add a parameter for turning error logs off #139

francescopellegrini opened this issue May 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@francescopellegrini
Copy link
Member

Similar to :log_response_on_error and :log_query_on_error I'd like to propose a new parameter to turn error logs off.
What do you think?

cc @davidedisomma

@dinopascale-prima dinopascale-prima added the enhancement New feature or request label May 15, 2024
@francescopellegrini
Copy link
Member Author

@cpiemontese @cottinisimone penny for your thoughts 💵

@cpiemontese
Copy link
Contributor

Hey! I see a few possibilities

  • something like :log_on_error which potentially overrides the other configs you mentioned
  • a more comprehensive refactor, something like :error_logs for logs where you can specify :all (i.e. log all errors) or just a subset like error_logs: [:response]

Spit-balling a bit, let me know what you think

@francescopellegrini
Copy link
Member Author

The latter looks more promising, but I think it also requires a larger effort.

@cpiemontese
Copy link
Contributor

Ok! We'll see what we can do then 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants