Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider usage of get_env for log_options #52

Open
cpiemontese opened this issue May 20, 2022 · 4 comments
Open

Reconsider usage of get_env for log_options #52

cpiemontese opened this issue May 20, 2022 · 4 comments

Comments

@cpiemontese
Copy link
Contributor

cpiemontese commented May 20, 2022

Right now we allow configuring :log_options from the environment (see here).

This should be avoided since it could lead to conflicts i.e. dependency & library using bridge_ex and overriding their configurations (see here for details).

This feature was allowed to let users configure logs only once for each environment and each bridge, but it could be a footgun.

@LeartS
Copy link

LeartS commented Jul 20, 2022

Definitely agreed. It makes it impossible for example to use bridge_ex in an umbrella app where the different subapps want to use different options.

@cpiemontese
Copy link
Contributor Author

I looked into it again: as of now, log_options can be configured both through the environment and locally during use.

If in an umbrella app, no sub-apps configure it using the environment, is it still impossible to use the library, or would that be a "workaround" (i.e. avoiding the foot gun)?

@LeartS
Copy link

LeartS commented Jul 27, 2022

I did not try but that should work. Thanks!

@cpiemontese
Copy link
Contributor Author

Ok, let us know! In any case we'll at the very least deprecate the "global" config and eventually remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants