Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider issue comments over commit comments #2

Open
klutchell opened this issue Oct 2, 2024 · 0 comments
Open

Consider issue comments over commit comments #2

klutchell opened this issue Oct 2, 2024 · 0 comments

Comments

@klutchell
Copy link
Collaborator

klutchell commented Oct 2, 2024

Commit comments are not obvious in the PR timeline and need to be pointed out for better UX.

image

Upon clicking on the tiny comment emoji, you are brought to the commit view for approval.

image

Another approach would be to comment directly on the PR and reference the commit SHA and workflow run.

A compromise may be to keep the commit comment, but also add a pointer comment on the PR itself referencing the latest commit requiring review. This comment would be updated automatically to point to the new commit.

All approaches need to be inspected for possible TOCTOU attacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant