-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could provide sample configs for other languages #84
Comments
And I've also just noticed that there are projects like https://github.com/resin-io/leech where it's just a bunch of shell scripts, so there's no "package manifest" file to update. |
Thinking a bit more about this, and prompted by balena-io-modules/open-balena-base#33 and balena-io-modules/device-diagnostics#9 (review) and balena-io-experimental/edge-node-manager#119 (review) ... Originally, every usage of However now that versionist and VersionBot are being deployed more widely over more and more resin.io repos, there are some repos where Ping @hedss @lekkas @brownjohnf @josephroberts @CameronDiver @imrehg |
There is now support for presets in versionist itself, which is probably the right way to go. What I'd like to see is a way to override only certain behavior/functions from the versionist config file without having to include the entire exports object. |
LOL, snap! ;) |
See also #100 |
#82 (comment) also provides another example of where versionist needs to be able to bump a version in a file-type not covered above. Given the awesome work @majorz did in #104 I wonder if a lot of the above file-types not already handled by versionist would be covered by e.g. a updateVersion: {
preset: 'quotedPatternReplace',
targetFile: 'meta-resin-common/conf/distro/include/resin-os.inc',
targetPattern: 'DISTRO_VERSION = '
} in replace(
'meta-resin-common/conf/distro/include/resin-os.inc',
/(DISTRO_VERSION = )("|').*?\2/,
'$1$2' + cleanedVersion + '$2',
done
); and this would then change e.g. If this works, it also means that the Python support @nghiant2710 added in #100 would be functionally equivalent to: updateVersion: {
preset: 'quotedPatternReplace',
targetFile: '__init__.py',
targetPattern: '__version__\s*=\s*'
} 😉 (of course I'm not suggesting that the Maybe the cc @hedss |
@lurch I think that's actually a really good idea (and yes, I think the ability to specify flags should also be included). |
This repo currently provides a
versionist.conf.js
tailored for NodeJS (npm) projects, which is the tech-stack used by many resin.io projects.However there are also some resin.io projects using other languages, like go, rust or python (etc.). To help with versionist-standardisation across all resin.io projects, it might be useful if this repo also provided sample config files for the other tech-stacks we use.
Suggested in: balena-io-experimental/edge-node-manager#175 (which possibly provides an example of where this would have been useful).
package.json
/npm-shrinkwrap.json
/package-lock.json
setup.py
/__init__.py
Cargo.toml
/Cargo.lock
keyframe.yml
The text was updated successfully, but these errors were encountered: