Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Apollo Server 4 #69

Open
veimox opened this issue Mar 18, 2023 · 6 comments
Open

Upgrade to Apollo Server 4 #69

veimox opened this issue Mar 18, 2023 · 6 comments

Comments

@veimox
Copy link

veimox commented Mar 18, 2023

➕ Enhancement Request

Apollo Server 4 changes how the packages are distributed. There is a migration guide that can be followed. It is basically to change the package names where the imports are coming from.

Problem related to enhancement request

By not doing this, there is a risk being obsolete or forcing users of this library to install libraries that they wouldn't do otherwise.

Sought-for solution

  • Feat release 4.1 #55 Could be the solution but I would rather doing it separately to make smaller changes. That PR has been open for basically a year so I really think is time to merge that one anyways.

Considered alternatives

  • Making a PR on top of Feat release 4.1 #55 but I would rather wait
  • Updating the README.md to state the limitations
@g7fernandes
Copy link
Member

g7fernandes commented Mar 21, 2023

For Apollo 4, I will have to do some further adaptations in the code, since the built-in apollo upload was removed. https://www.apollographql.com/docs/apollo-server/v2/data/file-uploads/#uploads-in-node-14-and-later

And we will add instructions about this CSRF attack prevention.

@amilich
Copy link

amilich commented Oct 21, 2023

Hey all, just checking in if v4 upgrade is planned or if this package is compatible with v4.

@amilich
Copy link

amilich commented Dec 20, 2023

No update :'( ?

@gwachhamit
Copy link

any update on this for apollo server 4?

@hugocruzlfc
Copy link

Hello good morning everyone, any news about the upgrade to Apollo 4?

@newerton
Copy link

I found this code that worked for my purpose. I'm using this code with NestJs.

https://gist.github.com/bl42/881d85ee0dd92bbe68e93dcd0c99cfdb

My libs versions:
"@apollo/federation": "^0.38.1",
"@apollo/gateway": "^2.9.1",
"@apollo/server": "^4.11.0",
"@apollo/subgraph": "^2.9.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants