From fa92a2eada88690a5e983e326065e48f1274f17f Mon Sep 17 00:00:00 2001 From: Snazzah Date: Tue, 17 Sep 2024 10:20:43 -0500 Subject: [PATCH 1/2] fix(DiscordRESTError): properly parse request errors --- lib/errors/DiscordRESTError.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/errors/DiscordRESTError.js b/lib/errors/DiscordRESTError.js index ba7ef58e..cef3ff3b 100644 --- a/lib/errors/DiscordRESTError.js +++ b/lib/errors/DiscordRESTError.js @@ -56,6 +56,12 @@ class DiscordRESTError extends Error { if(!Object.hasOwn(errors, fieldName) || fieldName === "message" || fieldName === "code") { continue; } + if(fieldName === "_errors") { + messages = messages.concat( + errors._errors.map((obj) => `${keyPrefix ? `${keyPrefix}: ` : ""}${obj.message}`) + ); + continue; + } if(errors[fieldName]._errors) { messages = messages.concat(errors[fieldName]._errors.map((obj) => `${keyPrefix + fieldName}: ${obj.message}`)); } else if(Array.isArray(errors[fieldName])) { From e6e313cbd3671b8ae4d475779baba33b907054d2 Mon Sep 17 00:00:00 2001 From: Snazzah <7025343+Snazzah@users.noreply.github.com> Date: Tue, 17 Sep 2024 12:47:44 -0500 Subject: [PATCH 2/2] chore: remove redundant continue Co-authored-by: TTtie --- lib/errors/DiscordRESTError.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/errors/DiscordRESTError.js b/lib/errors/DiscordRESTError.js index cef3ff3b..911e7a5a 100644 --- a/lib/errors/DiscordRESTError.js +++ b/lib/errors/DiscordRESTError.js @@ -60,9 +60,7 @@ class DiscordRESTError extends Error { messages = messages.concat( errors._errors.map((obj) => `${keyPrefix ? `${keyPrefix}: ` : ""}${obj.message}`) ); - continue; - } - if(errors[fieldName]._errors) { + } else if(errors[fieldName]._errors) { messages = messages.concat(errors[fieldName]._errors.map((obj) => `${keyPrefix + fieldName}: ${obj.message}`)); } else if(Array.isArray(errors[fieldName])) { messages = messages.concat(errors[fieldName].map((str) => `${keyPrefix + fieldName}: ${str}`));