Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spritesheets to the delivery method #18

Open
DaBs opened this issue Jun 8, 2016 · 2 comments
Open

Add spritesheets to the delivery method #18

DaBs opened this issue Jun 8, 2016 · 2 comments

Comments

@DaBs
Copy link

DaBs commented Jun 8, 2016

As titlen suggests. A user should be capable of requesting a spritesheet with a given array of icons in it. Discussion about implementation below.

@psolbach
Copy link
Owner

psolbach commented Jun 8, 2016

This is a feature I would very much like to see as well. Implementation might be hairy though. The whole concept of iconbin relies on the built-in "afterburner" we get with any file hosted on Github though MaxCDN. Generating images dynamically will require a dedicated caching layer. And the integration of C libs like imagemagick to composite Bitmaps is not something I would wanna tackle right now. However, we could offer individual downloads of SVG spritesheets that reference Base64 encoded bitmap data or other SVGs. Like so <image width="100" height="100" xlink:href="data:image/png;base64,...">.

@DaBs
Copy link
Author

DaBs commented Jun 10, 2016

Is it naive to believe that perhaps the spritesheet service should only be available for svgs, to, as you said yourself, rid us of having to do image manipulation for now?

I'm imagining that, much like the current solution, people can go into a SVG spritesheet editor and pick and choose the icons they'd like from the icon repo. Once a spritesheet has been made this way, it gets named according to a naming convention we have, saved to the GitHub repo and thus becomes something other users can take advantage of. Or the API could do the same automatically for you when you attempt a GET request, based on some parameters, just as long as we're not dealing with bitmaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants