Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved test assertions #34

Open
jywarren opened this issue Dec 6, 2019 · 1 comment
Open

Improved test assertions #34

jywarren opened this issue Dec 6, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@jywarren
Copy link
Member

jywarren commented Dec 6, 2019

We should be able to parse the returned data in tests to be sure they include an image; in general, tests are a little sparse; this tests did not fail although it errored:

https://travis-ci.org/publiclab/image-sequencer-app/builds/621629845?utm_source=github_status&utm_medium=notification

@jywarren
Copy link
Member Author

jywarren commented Dec 6, 2019

Here we could be parsing and running more specific assertions on the returned data:

.end((err, res) => {
res.should.be.any;
done();
});

I think it should be an HTML page with an embedded image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant