Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support to the app #38

Open
tech4GT opened this issue Jan 11, 2020 · 14 comments
Open

Add https support to the app #38

tech4GT opened this issue Jan 11, 2020 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@tech4GT
Copy link
Member

tech4GT commented Jan 11, 2020

No description provided.

@tech4GT tech4GT added the help wanted Extra attention is needed label Jan 11, 2020
@jywarren
Copy link
Member

Great, linking to publiclab/mapknitter#1191 as well!

@jywarren
Copy link
Member

jywarren commented Apr 8, 2020

Hi @tech4GT i hope you're well! We got the Ruby exporter online at https://stable.mapknitter.org today; docs here: https://publiclab.org/wiki/mapknitter-cloud-exporter

Next up will be connecting this one. I think SSL is still needed?

@tech4GT
Copy link
Member Author

tech4GT commented Apr 9, 2020

Hi @jywarren Long time! Actually my health has not been the best, past few months. Sorry for that. Could you point me to some docs about setting up https on google cloud? I've done it on aws quite a few times but I can't seem to find the docs for google cloud. Do they have something like certificateManager?

@jywarren
Copy link
Member

jywarren commented Apr 10, 2020

Oh gosh i'm sorry to hear that. Please don't worry about this if it's any distraction!

My first inclination was to try https://34.74.118.242/api/v2/export/?url=http://mapknitter.org/maps/ceres--2/warpables.json&scale=30 but SSL on an IP address doesn't seem quite right: https://stackoverflow.com/questions/2043617/is-it-possible-to-have-ssl-certificate-for-ip-address-not-domain-name#2043645

I guess we need to run it at https://exportjs.mapknitter.org or something.

One way to test this is to compare these two pages (say, swapping the export URL while running this locally, maybe?):

On looking closer i think this may be a question for @icarito -- I find this documentation on running SSL on a cluster in Google Cloud:

I will ask @icarito if this sounds familiar.

Best wishes for your health and please don't worry about this unless you really want to. Sending ❤️ and glad to hear from you!!

@jywarren
Copy link
Member

Input from @icarito --

so here is what I did: https://cloud.google.com/kubernetes-engine/docs/how-to/managed-certs
I think I edited the yaml files instead of creating new ones
here's the gist
"To configure a managed SSL certificate and associate it with an Ingress, you need to:

Create a ManagedCertificate object.
Associate the ManagedCertificate object to an Ingress by adding an annotation networking.gke.io/managed-certificates to the Ingress. This annotation is a comma-separated list of ManagedCertificate resources, cert1,cert2,cert3 for example.

The ManagedCertificate resource must be created in the same namespace as the Ingress."

@tech4GT
Copy link
Member Author

tech4GT commented Apr 13, 2020

Hi Jeff, thanks a lot for your wishes. I'll try my best to put in this work as soon as possible. I did go through this documentation but it looks like we would have to configure out exporter on a domain first, since to generate a certificate we need the domain that we'll be using. Anyway, would it be okay if we asked @icarito to help us on this since this uses a lot of stuff I'm not particularly familiar with. In any case I'll work my way through the documentation trying to make sense. 😊

@tech4GT
Copy link
Member Author

tech4GT commented Apr 13, 2020

I also found this article which documents the process pretty comprehensively! Also, could you please point me to our deployment on gcloud? Thanks!

@icarito
Copy link
Member

icarito commented Apr 13, 2020

Hi,
I'll look into this.
The current deployment can be found at http://34.74.118.242/

@icarito
Copy link
Member

icarito commented Apr 13, 2020

For now I've added a DNS entry at http://export-js.mapknitter.org/
I'll be working on get a managed certificate in the afternoon, to enable HTTPS.

@jywarren
Copy link
Member

jywarren commented Apr 14, 2020

@jywarren jywarren mentioned this issue Apr 14, 2020
5 tasks
@tech4GT
Copy link
Member Author

tech4GT commented Apr 14, 2020

Thanks a lot for your help @icarito 😊

@icarito
Copy link
Member

icarito commented Apr 21, 2020

Today I removed all deployment / services / ingresses related to this in our cluster, then went step by step thru https://cloud.google.com/kubernetes-engine/docs/how-to/managed-certs and still I get 502 server error from the external endpoint. I tried it without the ingress setup (just a load balancer) and it worked. Also the ingresses say backend services are UNHEALTHY whatever that means. I'll keep poking for solutions, sorry for the delay!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 4, 2020

Hi @jywarren I was trying out the export on http://34.74.118.242/api/v2/export/?url=. It does not load though.. did we move the deployment?

@icarito
Copy link
Member

icarito commented Jun 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants