'click to unfollow' is not working in /tag section

[Rishabh-Kumar-Bothra]

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

here we are not able to unfollow the tags direct which we are following and it is redirected to this page,
but we should be able to unfollow directly from /tags

Please show us where to look

https://publiclab.org/tags

What's your PublicLab.org username?

geekychaser

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[Rishabh-Kumar-Bothra]

@jywarren @SidharthBansal can i give it a try?

[oorjitchowdhary]

Hi @geekychaser .. I don't find any unfollow button on the page. I think the following button was meant to function like this...
However, I think we can change this. So instead of the following button we show unfollow and its function would be to remove that subscription

This seems good.

[Rishabh-Kumar-Bothra]

@oorjitchowdhary on hovering over the following its show click here to unfollow.

so on clicking it button should turn to follow again rather than redirecting to other page where we need to unfollow again

[oorjitchowdhary]

I just went through the issue on PL. You're right.
The following button should be firstly renamed to unfollow.
Then we see, if the button is clicked you're redirected to /unsubscribe/tag/tag_name. I think this where the problem is.
If you click unfollow on the /tags page or /subscriptions, you're redirected to some URL like subscriptions?_=1545829506

[oorjitchowdhary]

so on clicking it button should turn to follow again rather than redirecting to other page where we need to unfollow again

When you've successfully unsubscribed to a tag. You go to /tags again and then you'd have to refresh it once again to see it the button change to follow.

I think this page is missing AJAX. Sorry if I'm wrong

[Rishabh-Kumar-Bothra]

yes exactly this is the issue, and then you there again need to click on this button to this button to unfollow

[grvsachdeva]

Hi @geekychaser @oorjitchowdhary do you guys like to work on this issue together?

[jywarren]

I think we need to set the data-method to delete in the a tag here!

[SidharthBansal]

@gauravano I think both of them have abandoned this task.

[snpd25]

Hey @SidharthBansal , if no one is working on this issue, can I give it a try?

[SidharthBansal]

I think you can take this

…

On Tue, 8 Oct 2019, 7:51 am Sneha Prasad, ***@***.***> wrote: Hey @SidharthBansal <https://github.com/SidharthBansal> , if no one is working on this issue, can I give it a try? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4406?email_source=notifications&email_token=AFAAEQ5WNT2MIX7GAC5K6UTQNPVEJA5CNFSM4GMG2JO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEASNBLA#issuecomment-539283628>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQY3PHDF67NGRXSV3ODQNPVEJANCNFSM4GMG2JOQ> .

[renugasaraswathy]

Hi @gauravano @geekychasser, I would like to work on this issue. Could you assign it to me? Thanks.

[grvsachdeva]

Hi @renugasaraswathy, please go ahead. Thanks!

[KarishmaVanwari]

Hey @geekychasser @grvsachdeva , can I take up this issue, if it's open?

[cesswairimu]

Hi @KarishmaVanwari, The page has gone through some revamps and has fixed most of the issues discussed above. This is how it is currently:
The unfollow button still redirects to subscriptions page and we would love your help on this. Thanks

[cesswairimu]

💡Format this Issue Into a First Timers Issue

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting✍️, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled🏷. Or, if this is not your first time, try to solve it yourself🧑‍💻!

---

todo:

This is the method that is called on unfollow.

plots2/app/controllers/subscription_controller.rb

Lines 84 to 109 in e1d5fd7

	def delete
	# assume tag, for now
	if params[:type] == "tag"
	id = Tag.find_by(name: params[:name]).tid
	end
	if id.nil?
	flash[:error] = "You are not subscribed to '#{params[:name]}'"
	redirect_to "/subscriptions" + "?_=" + Time.now.to_i.to_s
	else
	if !set_following(false, params[:type], id) # should return false if result is that following == false
	respond_with do |format|
	format.html do
	if request.xhr?
	render json: true
	else
	flash[:notice] = "You have stopped following '#{params[:name]}'."
	redirect_to "/subscriptions" + "?_=" + Time.now.to_i.to_s
	end
	end
	end
	else
	flash[:error] = "Something went wrong!" # silly
	redirect_to "/subscriptions" + "?_=" + Time.now.to_i.to_s
	end
	end
	end

Replacing the redirects to redirect_to request.referrer should resolve this

[ghubrakesh]

Hello @cesswairimu, I would Like to take up this issue.

[cesswairimu]

hello @ghubrakesh, we would like your help...please go ahead, Thanks

[cesswairimu]

Converted this to an fto #11490. Closing this. Thanks all