Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instances of reflect.DeepEqual with equality.Semantic.DeepEqual for comparing unstructured k8s objects #3155

Open
blampe opened this issue Aug 7, 2024 · 0 comments
Open

Replace instances of reflect.DeepEqual with equality.Semantic.DeepEqual for comparing unstructured k8s objects #3155

blampe opened this issue Aug 7, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Aug 7, 2024 •
edited by rquitales
Loading

We should use https://pkg.go.dev/k8s.io/apimachinery/pkg/api/equality instead.
@blampe blampe added the kind/enhancement Improvements or new features label Aug 7, 2024
@rquitales rquitales changed the title Replace instances of DeepEqual with Replace instances of reflect.DeepEqual with equality.Semantic.DeepEqual for comparing unstructured k8s objects Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blampe