Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images don't display in email notifications from Gmail #371

Open
ewjoachim opened this issue Feb 27, 2024 · 6 comments
Open

Images don't display in email notifications from Gmail #371

ewjoachim opened this issue Feb 27, 2024 · 6 comments

Comments

@ewjoachim
Copy link
Member

ewjoachim commented Feb 27, 2024

I wonder if there's something we can do so that notification emails are more readable.
(this is from Gmail btw)

image

@ewjoachim
Copy link
Member Author

Works on other clients.
image

@mbrisson-ivadolabs
Copy link

I see the same issue using corporate gmail and Apple Mail

@ewjoachim
Copy link
Member Author

ewjoachim commented May 7, 2024

Hm, so I think it's because svg is not supported in many email clients.
Apparently, a simple change could be to switch from img.shields.io to raster.shields.io [edit] or changing .svg to .png[/]

Funnily enough, this could actually decrease the bandwith usage, as apparently on a few badges I've tried, the png is slightly smaller than the svg.

@ewjoachim
Copy link
Member Author

Ok, apparently the .png provided by shields.io are the exact size of the badge is supposed to appear, so on screens with high pixel density the badge is very ugly.
Until we find a way to fix this, I think I prefer the badge to appear right in github and not in gmail than ugly everywhere.

@ewjoachim
Copy link
Member Author

I did some tests in #414 and nothing satisfactory was found. This stays an open problem. Anyone with an idea, feel free.

@ewjoachim
Copy link
Member Author

Hm, alternative idea: embed the SVG. Does this work ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants