Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document possible exceptions #692

Open
kevinkjt2000 opened this issue Dec 12, 2023 · 1 comment
Open

Document possible exceptions #692

kevinkjt2000 opened this issue Dec 12, 2023 · 1 comment
Labels
area: API Related to core API of the project area: documentation Related to project's documentation (comments, docstrings, docs)

Comments

@kevinkjt2000
Copy link
Contributor

For reference, here are some of the possible exceptions (e.g. timeout #77 #97 #129 #135, ConnectionResetError #101, ConnectionRefusedError, gaierror, maybe custom exception wrappers in the future)

mcstatus could produce some exceptions of its own to wrap these exceptions we know about. As for the unknown ones, it could be enough to wrap those with the same base exception class that the rest of our custom exceptions inherit from.
@kevinkjt2000 kevinkjt2000 mentioned this issue Dec 12, 2023
Closed
14 tasks
@kevinkjt2000 kevinkjt2000 added area: documentation Related to project's documentation (comments, docstrings, docs) area: API Related to core API of the project labels Dec 12, 2023
@PerchunPak
Copy link
Member

Duplicate of #307

@PerchunPak PerchunPak marked this as a duplicate of #307 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: API Related to core API of the project area: documentation Related to project's documentation (comments, docstrings, docs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinkjt2000 @PerchunPak