Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not install for Python 3.7 due to opencv-python version mismatch #38

Open
RunOrVeith opened this issue Dec 13, 2018 · 2 comments
Open

Comments

@RunOrVeith
Copy link

RunOrVeith commented Dec 13, 2018

Description

Using python3.7, pip install pyannote-video does not work because of the hard version requirement opencv-python==3.4.1.15. As can be seen on the PyPy Page, version 3.4.1.15 can not be used with python 3.7.

Steps/Code to Reproduce

pip3.7 install pyannote-video

Expected Results

Pip installs pyannote-video

Actual Results

Collecting opencv-python==3.4.1.15 (from pyannote-video)
  Could not find a version that satisfies the requirement opencv-python==3.4.1.15 (from pyannote-video) (from versions: 3.4.2.17, 3.4.3.18, 3.4.4.19)
No matching distribution found for opencv-python==3.4.1.15 (from pyannote-video)

Fix

require opencv-python>=3.4.1.15 in setup.py. The current release version is 3.4.4.19.
As 3.4.4.19 also works for all the same python versions as 3.4.1.15 plus 3.7, the hard requirement version could probably also be increased. (This is untested, but I imagine there are no breaking changes between 3.4.1.15 and 3.4.4.19.)

@hbredin
Copy link
Member

hbredin commented Dec 17, 2018

Thanks for reporting this.

I'd gladly merge a pull request including this change as long as you also provide a script that I can run to test if it does not break anything.

@RunOrVeith
Copy link
Author

Unfortunately, I can not provide you with a full test suite that covers the whole repo (or did you mean something else?).
However, you can see here the file diffs between tag 3.4.4.15 and 3.4.4.19. It adds only installation changes, and updates the opencv submodule to version 3.4.4 (see commit messages here). You can read the ChangeLog for OpenCV here. It specifies a maintenance release, and some changes to the DNN module.
I highly doubt that OpenCV would introduce breaking changes going from version 3.4.1 to 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants