From 416fba83ea143a9e35cb3e03d450896f2bbffe1f Mon Sep 17 00:00:00 2001 From: Kai Harder Date: Thu, 30 Jul 2026 12:53:36 +0000 Subject: [PATCH] Fix type hint of create_or_update_secret The secret dict can have any value, e.g. a dict which is then stored as a JSON in vault --- stubs/hvac/hvac/api/secrets_engines/kv_v1.pyi | 4 +++- stubs/hvac/hvac/api/secrets_engines/kv_v2.pyi | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/stubs/hvac/hvac/api/secrets_engines/kv_v1.pyi b/stubs/hvac/hvac/api/secrets_engines/kv_v1.pyi index 3a9fc7072ac9..68117f2bdddb 100644 --- a/stubs/hvac/hvac/api/secrets_engines/kv_v1.pyi +++ b/stubs/hvac/hvac/api/secrets_engines/kv_v1.pyi @@ -1,3 +1,5 @@ +from typing import Any + from hvac.api.vault_api_base import VaultApiBase DEFAULT_MOUNT_POINT: str @@ -6,6 +8,6 @@ class KvV1(VaultApiBase): def read_secret(self, path: str, mount_point: str = "secret"): ... def list_secrets(self, path: str, mount_point: str = "secret"): ... def create_or_update_secret( - self, path: str, secret: dict[str, str], method: str | None = None, mount_point: str = "secret" + self, path: str, secret: dict[str, Any], method: str | None = None, mount_point: str = "secret" ): ... def delete_secret(self, path: str, mount_point: str = "secret"): ... diff --git a/stubs/hvac/hvac/api/secrets_engines/kv_v2.pyi b/stubs/hvac/hvac/api/secrets_engines/kv_v2.pyi index 7dcfdfb16748..6e838ffd152f 100644 --- a/stubs/hvac/hvac/api/secrets_engines/kv_v2.pyi +++ b/stubs/hvac/hvac/api/secrets_engines/kv_v2.pyi @@ -1,3 +1,5 @@ +from typing import Any + from hvac.api.vault_api_base import VaultApiBase DEFAULT_MOUNT_POINT: str @@ -15,7 +17,7 @@ class KvV2(VaultApiBase): def read_secret_version( self, path: str, version: int | None = None, mount_point: str = "secret", raise_on_deleted_version: bool | None = None ): ... - def create_or_update_secret(self, path: str, secret: dict[str, str], cas: int | None = None, mount_point: str = "secret"): ... + def create_or_update_secret(self, path: str, secret: dict[str, Any], cas: int | None = None, mount_point: str = "secret"): ... def patch(self, path: str, secret: dict[str, str], mount_point: str = "secret"): ... def delete_latest_version_of_secret(self, path: str, mount_point: str = "secret"): ... def delete_secret_versions(self, path: str, versions: list[int], mount_point: str = "secret"): ...