Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reference for starsky.feature.trash to starsky.feature.metaupdate #1778

Open
qdraw opened this issue Oct 18, 2024 · 0 comments
Open

Wrong reference for starsky.feature.trash to starsky.feature.metaupdate #1778

qdraw opened this issue Oct 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@qdraw
Copy link
Owner

qdraw commented Oct 18, 2024

Describe the bug
The starsky.feature.trash project references the starsky.feature.metaupdate project, which violates the Helix principles. This reference should be refactored so that starsky.feature.trash no longer depends on starsky.feature.metaupdate.

To Reproduce
Steps to reproduce the behavior:

  1. Open the starsky.feature.trash project file (starsky.feature.trash.csproj).
  2. Locate the ProjectReference to starsky.feature.metaupdate.
  3. Observe that the starsky.feature.trash project references starsky.feature.metaupdate.

Expected behavior
The starsky.feature.trash project should not reference the starsky.feature.metaupdate project. Instead, any shared functionality should be moved to a foundation project that both features can reference.

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context
This issue is a known problem and should be addressed by refactoring the shared functionality into a foundation project to maintain compliance with Helix principles.

@qdraw qdraw added the bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant