Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit output URI #235

Closed
drernie opened this issue Sep 4, 2024 · 4 comments · Fixed by #237
Closed

explicit output URI #235

drernie opened this issue Sep 4, 2024 · 4 comments · Fixed by #237
Assignees

Comments

@drernie
Copy link
Member

drernie commented Sep 4, 2024

Pull uri directly from pubDir/outDir (configurable), and validate based on output (rather than vice versa)

  1. Get Params
  2. Find single output URI
  3. List of valid keys, in order
  4. Can override via config.quilt.outputKeys
  5. Infer PackageURI if not already
  6. Track dest Key (always?), pass to push
  7. Still track non-QuiltPath outputs for overlay and checking
  8. Verify that actual outputs match the expected URI; if not, issue a warning
@drernie
Copy link
Member Author

drernie commented Sep 4, 2024

@drernie drernie self-assigned this Sep 4, 2024
@drernie drernie linked a pull request Sep 4, 2024 that will close this issue
@drernie
Copy link
Member Author

drernie commented Sep 8, 2024

Tower error for S3 URIs

Downloading plugin nf-quilt@0.8.3
WARN: Unrecognized output URI: copy
ERROR ~ Cannot invoke "nextflow.quilt.nio.QuiltPath.getBucket()" because "path" is null

Local error for quilt URIs

$ make PIPELINE=rnaseq rnaseq
ERROR ~ onFilePublish: no match for udp-spec#package=nf-quilt%2frnaseq&path=pipeline_info%2fexecution_trace_2024-09-08_10-10-48.txt

@drernie
Copy link
Member Author

drernie commented Sep 10, 2024

Fixed! Creates package! Sort of:
https://nightly.quilttest.com/b/quilt-example-bucket/packages/test/nfquilt_v080_test_rnaseq_3/tree/5ff3621b86bffea280de7fae2057588dfa3b2ff65c4278b5f3d361bc7b33c4eb/

Lacks subfolders apparently created in:
https://nightly.quilttest.com/b/quilt-example-bucket/tree/test/nfquilt_v080_test_rnaseq_3/

Oddly, the source does NOT seem to have the subfolder:

Sep-10 19:50:37.620 [PublishDir-4] DEBUG nextflow.quilt.QuiltObserver - onFilePublish.Path[/quilt-example-bucket/test/nfquilt_v080_test_rnaseq_3/salmon/RAP1_UNINDUCED_REP2] <- /quilt-demos/scratch/7FSCV3ZE0whSy/a5/dd1ac988ec91d7ded99767fe231f05/RAP1_UNINDUCED_REP2

@drernie
Copy link
Member Author

drernie commented Sep 12, 2024

drernie added a commit that referenced this issue Sep 12, 2024
#235 and friends

---------

Co-authored-by: Dr. Ernie Prabhakar <19791+drernie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant