Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extraneous 'id' fields #4

Open
mr-c opened this issue May 7, 2020 · 4 comments
Open

remove extraneous 'id' fields #4

mr-c opened this issue May 7, 2020 · 4 comments
Assignees

Comments

@mr-c
Copy link
Contributor

mr-c commented May 7, 2020

Some CWL generators, like cwlgen, output map<> format but still retain the id in the map entry's values, even though the 'id' value is also the map key.

This should be stripped out.

Example: https://github.com/PMCC-BioinformaticsCore/janis-pipelines/blob/536f8181dd3edaa7339483cc28610e3acde5d105/janis_pipelines/wgs_germline/cwl/WGSGermlineMultiCallers.cwl#L22

inputs:
  align_and_sort_sortsam_tmpDir:
    id: align_and_sort_sortsam_tmpDir
    doc: Undocumented option
    type: string
    default: ./tmp
@ghost
Copy link

ghost commented May 7, 2020

@ghost
Copy link

ghost commented May 7, 2020

But when that question is resolved, this will probably be merged into #1 ?

@mr-c
Copy link
Contributor Author

mr-c commented May 7, 2020

@mr-c common-workflow-language/common-workflow-language#518

We fixed the formatting of the HTML output and added https://www.commonwl.org/v1.1/CommandLineTool.html#map to address that

@mr-c
Copy link
Contributor Author

mr-c commented May 7, 2020

But when that question is resolved, this will probably be merged into #1 ?

Probably!

@ghost ghost assigned mr-c Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant