Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max length for tree path #2

Open
radiac opened this issue Oct 16, 2015 · 0 comments
Open

Max length for tree path #2

radiac opened this issue Oct 16, 2015 · 0 comments

Comments

@radiac
Copy link
Owner

radiac commented Oct 16, 2015

The max slug length of 255 seems reasonable for tag fields, but that could quickly lead to some very long paths in tag trees. If we take 2000 chars as the upper URL limit, we can set a default of 1900 to allow for most options, and document that the start of a path URL can only safely be 100 chars long.

The main problem with this is that paths are auto-generated, so we have to manage this automatically. I suggest that once a path gets to eg 500 characters its no longer human-readable anyway, so instead of using tag slugs in the path, we use tag ids (for the children of the first tag to break the 500 char limit).

These limits will be configurable as site-wide settings. Upgrade instructions will need to warn of the change.

@radiac radiac changed the title Max length for path Max length for tree path Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant